Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-101538: Add experimental wasi-threads build#101537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
brettcannon merged 9 commits intopython:mainfromyamt:wasi-threads
Jun 22, 2023

Conversation

yamt
Copy link
Contributor

@yamtyamt commentedFeb 3, 2023•
edited
Loading

eg.

export WASI_SDK_PATH=/opt/wasi-sdk-19.5g0236e959edbc./Tools/wasm/wasm_build.py wasi-threads build~/git/toywasm/b.thread/toywasm --wasi --wasi-dir . --wasi-dir ~/git/garbage/py/th2 -- builddir/wasi-threads/python.wasm ~/git/garbage/py/th2/thread.py

  • I used an unreleased version of wasi-sdk

  • I used toywasm to test because wasmtime doesn't have
    necessary functionality yet.

@bedevere-bot
Copy link

Most changes to Pythonrequire a NEWS entry.

Please add it using theblurb_it web app or theblurb command-line tool.

@ghost
Copy link

ghost commentedFeb 3, 2023•
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-bot
Copy link

Most changes to Pythonrequire a NEWS entry.

Please add it using theblurb_it web app or theblurb command-line tool.

@arhadthedevarhadthedev added interpreter-core(Objects, Python, Grammar, and Parser dirs) OS-wasi labelsFeb 3, 2023
@arhadthedev
Copy link
Member

Would you mind adding the news entry as the bot suggests?Add experimental wasi-threads support. Patch by Takashi Yamamoto. is sufficient.

@bedevere-bot
Copy link

Most changes to Pythonrequire a NEWS entry.

Please add it using theblurb_it web app or theblurb command-line tool.

@yamtyamt changed the titleAdd experimental wasi-threads buildgh-101538: Add experimental wasi-threads buildFeb 3, 2023
eg.```autoconfexport WASI_SDK_PATH=/opt/wasi-sdk-19.5g0236e959edbc./Tools/wasm/wasm_build.py wasi-threads build~/git/toywasm/b.thread/toywasm --wasi --wasi-dir . --wasi-dir ~/git/garbage/py/th2 -- builddir/wasi-threads/python.wasm ~/git/garbage/py/th2/thread.py```* I used an unreleased version of wasi-sdk* I used toywasm to test because wasmtime doesn't have  necessary functionality yet.
@yamt
Copy link
ContributorAuthor

yamt commentedFeb 3, 2023

Would you mind adding the news entry as the bot suggests?Add experimental wasi-threads support. Patch by Takashi Yamamoto. is sufficient.

thank you. done.

arhadthedev reacted with thumbs up emoji

```docker run --rm -v $(pwd):/src quay.io/tiran/cpython_autoconf:269```
@arhadthedev
Copy link
Member

No need to rebase and force-push; everything will be squashed into a single commit while merging anyway.

erlend-aasland reacted with thumbs up emoji

@yamt
Copy link
ContributorAuthor

yamt commentedFeb 3, 2023

No need to rebase and force-push; everything will be squashed into a single commit while merging anyway.

ok. i was not aware of the policy. thank you.

@erlend-aasland
Copy link
Contributor

ok. i was not aware of the policy. thank you.

It is documented in the devguide:https://devguide.python.org/getting-started/pull-request-lifecycle/#submitting

@yamt
Copy link
ContributorAuthor

yamt commentedFeb 6, 2023

ok. i was not aware of the policy. thank you.

It is documented in the devguide:https://devguide.python.org/getting-started/pull-request-lifecycle/#submitting

ok. i was aware of the doc. but apparently i haven't read it carefully enough. thank you for pointing out.

erlend-aasland reacted with thumbs up emoji

@brettcannon
Copy link
Member

As I rejected the feature request I am also unfortunately rejecting this PR.

erlend-aasland reacted with thumbs up emoji

@brettcannon
Copy link
Member

FYI in case this PR gets re-opened (instead of a new one) when WASI threads goes stable, I was able to build with WASI SDK 20 and this PR.

@brettcannon
Copy link
Member

@yamt I got tacit approval to turn this on as long as it is clearly marked as experimental. Did you want to refresh this PR as necessary?

erlend-aasland reacted with thumbs up emoji

@erlend-aasland
Copy link
Contributor

@yamt, I marked our Autoconf conversation as resolved and also took the liberty to apply a small Autoconf style change. Hope you don't mind.

@yamt
Copy link
ContributorAuthor

@yamt, I marked our Autoconf conversation as resolved and also took the liberty to apply a small Autoconf style change. Hope you don't mind.

thank you.

@erlend-aasland
Copy link
Contributor

erlend-aasland commentedJun 22, 2023•
edited
Loading

AFAICS, we can land this now,@brettcannon. I'll wait a couple of days to give you a chance to look over it before merging :)

brettcannon reacted with thumbs up emoji

@brettcannon
Copy link
Member

It's experimental (and even undocumented ATM 😅), so I'm good with it.

@brettcannonbrettcannon merged commitd8f87cd intopython:mainJun 22, 2023
@brettcannon
Copy link
Member

@yamt Thanks! I will updatehttps://github.com/brettcannon/cpython-wasi-build probably in the next week or so to start producing a threaded build for WASI on top of the "normal" build w/o threads.

bentasker pushed a commit to bentasker/cpython that referenced this pull requestJun 23, 2023
Co-authored-by: Brett Cannon <brett@python.org>Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@brettcannon
Copy link
Member

@Yhg1s is it okay to backport this to 3.12?

@Yhg1s
Copy link
Member

Yes, this is fine for 3.12 (if it gets into RC1, scheduled for 2 weeks from now).

brettcannon reacted with hooray emoji

@erlend-aaslanderlend-aasland added the needs backport to 3.12only security fixes labelJul 17, 2023
@miss-islington
Copy link
Contributor

Thanks@yamt for the PR, and@brettcannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-106834 is a backport of this pull request to the3.12 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.12only security fixes labelJul 17, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJul 17, 2023
(cherry picked from commitd8f87cd)Co-authored-by: YAMAMOTO Takashi <yamamoto@midokura.com>Co-authored-by: Brett Cannon <brett@python.org>Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
erlend-aasland added a commit that referenced this pull requestJul 17, 2023
…06834)(cherry picked from commitd8f87cd)Co-authored-by: YAMAMOTO Takashi <yamamoto@midokura.com>Co-authored-by: Brett Cannon <brett@python.org>Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@erlend-aaslanderlend-aaslanderlend-aasland approved these changes

@corona10corona10Awaiting requested review from corona10corona10 is a code owner

Assignees
No one assigned
Labels
interpreter-core(Objects, Python, Grammar, and Parser dirs)OS-wasi
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

7 participants
@yamt@bedevere-bot@arhadthedev@erlend-aasland@brettcannon@Yhg1s@miss-islington
[8]ページ先頭
©2009-2025 Movatter.jp