Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.4k
Fixes typo in asyncio.TaskGroup context manager code example#101449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
ghost commentedJan 31, 2023 • edited by ghost
Loading Uh oh!
There was an error while loading.Please reload this page.
edited by ghost
Uh oh!
There was an error while loading.Please reload this page.
All commit authors signed the Contributor License Agreement. |
gvanrossum left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Good catch, and this is sufficiently semantically subtle that it is worth fixing. Thanks!
miss-islington commentedJan 31, 2023
Thanks@bcla22 for the PR, and@gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
bedevere-bot commentedJan 31, 2023
GH-101450 is a backport of this pull request to the3.11 branch. |
(cherry picked from commitef09bf6)Co-authored-by: Ben <22038077+bcla22@users.noreply.github.com>
* main:pythongh-101440: fix json snippet error in logging-cookbook.rst (python#101439)pythongh-99276 - Updated Doc/faq/general.rst (python#101396) Add JOBS parameter to docs Makefile (python#101395)pythongh-98831: rewrite GET_LEN, GET_ITER, BEFORE_WITH and a few simple opcodes in the instruction definition DSL (python#101443)pythongh-77607: Improve accuracy of os.path.join docs (python#101406) Fixes typo in asyncio.TaskGroup context manager code example (python#101449)pythongh-98831: Clean up and add cache size static_assert to macro (python#101442)pythongh-99955: use SUCCESS/ERROR return values in optimizer and assembler. Use RETURN_IF_ERROR where appropriate. Fix a couple of bugs. (python#101412)
In the docs, an example using an
asyncio.TaskGroupcontext manager to create two tasks and execute them concurrently has a comment which reads "The wait is implicit when the context manager exits.". Likely this is meant to read "Theawait is implicit when the context manager exits".