Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
gh-98831: rewrite GET_LEN, GET_ITER, BEFORE_WITH and a few simple opcodes in the instruction definition DSL#101443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…le opcodes in the instruction definition DSL
gvanrossum left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
There might be leaks. :-(
Python/bytecodes.c Outdated
| gotoerror; | ||
| ERROR_IF(true,error); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I believe this leaks a reference tomgr. You can either insert anotherDECREF_INPUTS() before this line, or just keep thegoto error. I prefer the latter, we're not going to require usingDECREF_INPUTS() everywhere (it mostly exists because it would be useful with the register conversion).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'm was just looking at this. I added DECREF_INPUTS in these two places and it is still leaking something.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I pushed the change with goto, still looking for the other leak.
Python/bytecodes.c Outdated
| gotoerror; | ||
| ERROR_IF(true,error); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Same here.
Python/generated_cases.c.h Outdated
| gotoerror; | ||
| } | ||
| PUSH(res); | ||
| if (res==NULL)gotopop_1_error; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It's leaking whenenter raises.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It leaks exit. Before this PR it put exit in the stack before the 'goto error', but now it doesn't so it needs to decref exit.
bedevere-bot commentedJan 31, 2023
🤖 New build scheduled with the buildbot fleet by@iritkatriel for commit2ee6241 🤖 If you want to schedule another build, you need to add the |
2 similar comments
bedevere-bot commentedJan 31, 2023
🤖 New build scheduled with the buildbot fleet by@iritkatriel for commit2ee6241 🤖 If you want to schedule another build, you need to add the |
bedevere-bot commentedJan 31, 2023
🤖 New build scheduled with the buildbot fleet by@iritkatriel for commit2ee6241 🤖 If you want to schedule another build, you need to add the |
bedevere-bot commentedJan 31, 2023
🤖 New build scheduled with the buildbot fleet by@iritkatriel for commita925498 🤖 If you want to schedule another build, you need to add the |
gvanrossum left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
That LGTM, but there's still something that claims to leak -- importlib, no less. Let me re-run that build.
gvanrossum commentedJan 31, 2023
The PPC64 buildbots are simply out of disk space. (I think it may be the same machine.) |
…le opcodes in the instruction definition DSL (python#101443)
* main:pythongh-101440: fix json snippet error in logging-cookbook.rst (python#101439)pythongh-99276 - Updated Doc/faq/general.rst (python#101396) Add JOBS parameter to docs Makefile (python#101395)pythongh-98831: rewrite GET_LEN, GET_ITER, BEFORE_WITH and a few simple opcodes in the instruction definition DSL (python#101443)pythongh-77607: Improve accuracy of os.path.join docs (python#101406) Fixes typo in asyncio.TaskGroup context manager code example (python#101449)pythongh-98831: Clean up and add cache size static_assert to macro (python#101442)pythongh-99955: use SUCCESS/ERROR return values in optimizer and assembler. Use RETURN_IF_ERROR where appropriate. Fix a couple of bugs. (python#101412)
Uh oh!
There was an error while loading.Please reload this page.