NotificationsYou must be signed in to change notification settings
Fork33.4k
Star69.8k

gh-101440: fix json snippet error in logging-cookbook.rst#101439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

hugovk merged 1 commit intopython:mainfrompeterjpxie:fix_json_error_in_logging-cookbook.rst

Jan 31, 2023

Merged

gh-101440: fix json snippet error in logging-cookbook.rst#101439

hugovk merged 1 commit intopython:mainfrompeterjpxie:fix_json_error_in_logging-cookbook.rst

Jan 31, 2023

Conversation

Copy link

Contributor

peterjpxie commentedJan 30, 2023•
edited by bedevere-bot
Loading

remove the extra comma (,)

Issue:extra comma (,) in the json snippet in Doc/howto/logging-cookbook.rst #101440

fix json snippet error in logging-cookbook.rst

d4d4561

peterjpxie requested a review fromvsajip as acode owner

January 30, 2023 22:32

bedevere-bot added awaiting review docs

Documentation in the Doc dir

skip news labels

Jan 30, 2023

peterjpxie changed the title~~fix json snippet error in logging-cookbook.rst~~gh-101440: fix json snippet error in logging-cookbook.rst

Jan 30, 2023

bedevere-bot mentioned this pull request

Jan 30, 2023

extra comma (,) in the json snippet in Doc/howto/logging-cookbook.rst#101440

Closed

rhettinger approved these changes

Jan 30, 2023

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting review labels

Jan 30, 2023

hugovk added needs backport to 3.10

only security fixes

needs backport to 3.11only security fixes labels

Jan 31, 2023

hugovk approved these changes

Jan 31, 2023

View reviewed changes

sobolevn approved these changes

Jan 31, 2023

View reviewed changes

Copy link

Member

sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This was not a valid JSON, trailing commas are not allowed (except forjson5).

Thanks!

hugovk merged commit20c11f2 intopython:main

Jan 31, 2023

Copy link

Contributor

miss-islington commentedJan 31, 2023

Thanks@peterjpxie for the PR, and@hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

bedevere-bot removed the awaiting merge label

Jan 31, 2023

Copy link

bedevere-bot commentedJan 31, 2023

GH-101463 is a backport of this pull request to the3.11 branch.

bedevere-bot removed the needs backport to 3.11only security fixes label

Jan 31, 2023

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jan 31, 2023

pythongh-101440: fix json snippet error in logging-cookbook.rst (pyth…

17150be

…onGH-101439)(cherry picked from commit20c11f2)Co-authored-by: Peter Jiping Xie <peter.jp.xie@gmail.com>

Copy link

bedevere-bot commentedJan 31, 2023

GH-101464 is a backport of this pull request to the3.10 branch.

bedevere-bot removed the needs backport to 3.10only security fixes label

Jan 31, 2023

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jan 31, 2023

pythongh-101440: fix json snippet error in logging-cookbook.rst (pyth…

e3a6df6

…onGH-101439)(cherry picked from commit20c11f2)Co-authored-by: Peter Jiping Xie <peter.jp.xie@gmail.com>

miss-islington added a commit that referenced this pull request

Jan 31, 2023

gh-101440: fix json snippet error in logging-cookbook.rst (GH-101439)

6b2ed1c

(cherry picked from commit20c11f2)Co-authored-by: Peter Jiping Xie <peter.jp.xie@gmail.com>

miss-islington added a commit that referenced this pull request

Jan 31, 2023

[3.11]gh-101440: fix json snippet error in logging-cookbook.rst (GH-…

5e49807

…101439) (GH-101463)(cherry picked from commit20c11f2)Co-authored-by: Peter Jiping Xie <peter.jp.xie@gmail.com>Automerge-Triggered-By: GH:hugovk

mdboom pushed a commit to mdboom/cpython that referenced this pull request

Jan 31, 2023

pythongh-101440: fix json snippet error in logging-cookbook.rst (pyth…

371a25e

…on#101439)

carljm added a commit to carljm/cpython that referenced this pull request

Jan 31, 2023

Merge branch 'main' into inlinecomp2

ed3209b

* main:pythongh-101440: fix json snippet error in logging-cookbook.rst (python#101439)pythongh-99276 - Updated Doc/faq/general.rst (python#101396)  Add JOBS parameter to docs Makefile (python#101395)pythongh-98831: rewrite GET_LEN, GET_ITER, BEFORE_WITH and a few simple opcodes in the instruction definition DSL (python#101443)pythongh-77607: Improve accuracy of os.path.join docs (python#101406)  Fixes typo in asyncio.TaskGroup context manager code example (python#101449)pythongh-98831: Clean up and add cache size static_assert to macro (python#101442)pythongh-99955: use SUCCESS/ERROR return values in optimizer and assembler. Use RETURN_IF_ERROR where appropriate. Fix a couple of bugs. (python#101412)