Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
gh-77607: Improve accuracy of os.path.join docs#101406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This is a follow-up topython#100811.One of the changes in that PR isn't accurate in that`os.path.join('', '')` will not end in a separator.This reverts that change to the previous wording that used "only", butexplicitly calls out the case where the last part ends in a separator,which is what caused confusin inpython#77607 and motivated the changeinpython#100811.
slateny approved these changesJan 30, 2023
Contributor
slateny left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
lgtm, thanks 🙂
Contributor
miss-islington commentedJan 31, 2023
Thanks@hauntsaninja for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJan 31, 2023
This is a follow-up topythonGH-100811.One of the changes in that PR isn't accurate in that`os.path.join('', '')` will not end in a separator.This reverts that change to the previous wording that used "only", butexplicitly calls out the case where the last part ends in a separator,which is what caused confusin inpythonGH-77607 and motivated the changeinpythonGH-100811.(cherry picked from commit909a674)Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
bedevere-bot commentedJan 31, 2023
GH-101451 is a backport of this pull request to the3.11 branch. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJan 31, 2023
This is a follow-up topythonGH-100811.One of the changes in that PR isn't accurate in that`os.path.join('', '')` will not end in a separator.This reverts that change to the previous wording that used "only", butexplicitly calls out the case where the last part ends in a separator,which is what caused confusin inpythonGH-77607 and motivated the changeinpythonGH-100811.(cherry picked from commit909a674)Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
bedevere-bot commentedJan 31, 2023
GH-101452 is a backport of this pull request to the3.10 branch. |
miss-islington added a commit that referenced this pull requestJan 31, 2023
This is a follow-up toGH-100811.One of the changes in that PR isn't accurate in that`os.path.join('', '')` will not end in a separator.This reverts that change to the previous wording that used "only", butexplicitly calls out the case where the last part ends in a separator,which is what caused confusin inGH-77607 and motivated the changeinGH-100811.(cherry picked from commit909a674)Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
miss-islington added a commit that referenced this pull requestJan 31, 2023
This is a follow-up toGH-100811.One of the changes in that PR isn't accurate in that`os.path.join('', '')` will not end in a separator.This reverts that change to the previous wording that used "only", butexplicitly calls out the case where the last part ends in a separator,which is what caused confusin inGH-77607 and motivated the changeinGH-100811.(cherry picked from commit909a674)Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
mdboom pushed a commit to mdboom/cpython that referenced this pull requestJan 31, 2023
This is a follow-up topython#100811.One of the changes in that PR isn't accurate in that`os.path.join('', '')` will not end in a separator.This reverts that change to the previous wording that used "only", butexplicitly calls out the case where the last part ends in a separator,which is what caused confusin inpython#77607 and motivated the changeinpython#100811.
carljm added a commit to carljm/cpython that referenced this pull requestJan 31, 2023
* main:pythongh-101440: fix json snippet error in logging-cookbook.rst (python#101439)pythongh-99276 - Updated Doc/faq/general.rst (python#101396) Add JOBS parameter to docs Makefile (python#101395)pythongh-98831: rewrite GET_LEN, GET_ITER, BEFORE_WITH and a few simple opcodes in the instruction definition DSL (python#101443)pythongh-77607: Improve accuracy of os.path.join docs (python#101406) Fixes typo in asyncio.TaskGroup context manager code example (python#101449)pythongh-98831: Clean up and add cache size static_assert to macro (python#101442)pythongh-99955: use SUCCESS/ERROR return values in optimizer and assembler. Use RETURN_IF_ERROR where appropriate. Fix a couple of bugs. (python#101412)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This is a follow-up to#100811.
One of the changes in that PR isn't accurate in that
os.path.join('', '')will not end in a separator.This reverts that change to the previous wording that used "only", but explicitly calls out the case where the last part ends in a separator, which is what caused confusion in#77607 and motivated the change in#100811.