Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-99276 - Updated Doc/faq/general.rst#101396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
hugovk merged 10 commits intopython:mainfromworkingpayload:workingpayload/issue99276
Jan 31, 2023
Merged

gh-99276 - Updated Doc/faq/general.rst#101396

hugovk merged 10 commits intopython:mainfromworkingpayload:workingpayload/issue99276
Jan 31, 2023

Conversation

@workingpayload
Copy link
Contributor

@workingpayloadworkingpayload commentedJan 28, 2023
edited by bedevere-bot
Loading

@ghost
Copy link

ghost commentedJan 28, 2023
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

Copy link
Member

@hugovkhugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for the PR, but:

Issuegh-99276 was about adding thehttps://ir.cwi.nl/pub/18204 article link to that articles section:

Please could you update the PR?

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@workingpayload
Copy link
ContributorAuthor

Thanks for the PR, but:

Issuegh-99276 was about adding thehttps://ir.cwi.nl/pub/18204 article link to that articles section:

Please could you update the PR?

Yeah Sure!!

@workingpayload
Copy link
ContributorAuthor

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@hugovk: please review the changes made to this pull request.

@hugovk
Copy link
Member

Rather than adding that extra line, shall we add an inline link?

For example, to add the link around "very first article":

-The very first article about Python was written in 1991 and is now quite-outdated.+The `very first article <https://ir.cwi.nl/pub/18204>` about Python was+written in 1991 and is now quite outdated.

@workingpayload
Copy link
ContributorAuthor

Rather than adding that extra line, shall we add an inline link?

For example, to add the link around "very first article":

-The very first article about Python was written in 1991 and is now quite-outdated.+The `very first article <https://ir.cwi.nl/pub/18204>` about Python was+written in 1991 and is now quite outdated.

Yeah sure!!
I'll do that.
Thank you for helping me out.

hugovk reacted with thumbs up emoji

@workingpayload
Copy link
ContributorAuthor

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@hugovk: please review the changes made to this pull request.

@workingpayload
Copy link
ContributorAuthor

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@hugovk: please review the changes made to this pull request.

workingpayloadand others added2 commitsJanuary 30, 2023 15:29
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Copy link
Member

@hugovkhugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks!

workingpayload reacted with heart emoji
@hugovkhugovk added needs backport to 3.10only security fixes needs backport to 3.11only security fixes labelsJan 30, 2023
@hugovkhugovk merged commitdf0068c intopython:mainJan 31, 2023
@miss-islington
Copy link
Contributor

Thanks@workingpayload for the PR, and@hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

workingpayload reacted with heart emoji

@bedevere-bot
Copy link

GH-101461 is a backport of this pull request to the3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.11only security fixes labelJan 31, 2023
@bedevere-bot
Copy link

GH-101462 is a backport of this pull request to the3.10 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.10only security fixes labelJan 31, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJan 31, 2023
(cherry picked from commitdf0068c)Co-authored-by: Raj <51259329+workingpayload@users.noreply.github.com>Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJan 31, 2023
(cherry picked from commitdf0068c)Co-authored-by: Raj <51259329+workingpayload@users.noreply.github.com>Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
miss-islington added a commit that referenced this pull requestJan 31, 2023
(cherry picked from commitdf0068c)Co-authored-by: Raj <51259329+workingpayload@users.noreply.github.com>Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
hugovk added a commit that referenced this pull requestJan 31, 2023
Co-authored-by: Raj <51259329+workingpayload@users.noreply.github.com>Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
mdboom pushed a commit to mdboom/cpython that referenced this pull requestJan 31, 2023
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
carljm added a commit to carljm/cpython that referenced this pull requestJan 31, 2023
* main:pythongh-101440: fix json snippet error in logging-cookbook.rst (python#101439)pythongh-99276 - Updated Doc/faq/general.rst (python#101396)  Add JOBS parameter to docs Makefile (python#101395)pythongh-98831: rewrite GET_LEN, GET_ITER, BEFORE_WITH and a few simple opcodes in the instruction definition DSL (python#101443)pythongh-77607: Improve accuracy of os.path.join docs (python#101406)  Fixes typo in asyncio.TaskGroup context manager code example (python#101449)pythongh-98831: Clean up and add cache size static_assert to macro (python#101442)pythongh-99955: use SUCCESS/ERROR return values in optimizer and assembler. Use RETURN_IF_ERROR where appropriate. Fix a couple of bugs. (python#101412)
@workingpayloadworkingpayload deleted the workingpayload/issue99276 branchFebruary 1, 2023 16:59
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@hugovkhugovkhugovk approved these changes

Assignees

No one assigned

Labels

docsDocumentation in the Doc dirskip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@workingpayload@bedevere-bot@hugovk@miss-islington

[8]ページ先頭

©2009-2025 Movatter.jp