Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.1k
[3.10] [3.11] gh-99952: fix refcount issues in ctypes.Structure from_param() result (GH-101339)#101340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…aram() result (pythonGH-101339)[3.11]pythongh-99952: [ctypes] fix refcount issues in from_param() result. (pythonGH-100169)Fixes a reference counting issue with `ctypes.Structure` when a `from_param()` method call is used and the structure size is larger than a C pointer `sizeof(void*)`.This problem existed for a very long time, but became more apparent in 3.8+ by change likely due to garbage collection cleanup timing changes..(cherry picked from commitdfad678)(cherry picked from commitfa7c37a)Co-authored-by: Gregory P. Smith <greg@krypto.org>Co-authored-by: Yukihiro Nakadaira <yukihiro.nakadaira@gmail.com>
gpshead approved these changesJan 26, 2023
Sorry, I can't merge this PR. Reason: |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
[3.11]gh-99952: [ctypes] fix refcount issues in from_param() result. (GH-100169)
Fixes a reference counting issue with
ctypes.Structurewhen afrom_param()method call is used and the structure size is larger than a C pointersizeof(void*).This problem existed for a very long time, but became more apparent in 3.8+ by change likely due to garbage collection cleanup timing changes..
(cherry picked from commitdfad678)
(cherry picked from commitfa7c37a)
Co-authored-by: Gregory P. Smithgreg@krypto.org
Co-authored-by: Yukihiro Nakadairayukihiro.nakadaira@gmail.com
Automerge-Triggered-By: GH:gpshead