Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-101317: Add ssl_shutdown_timeout parameter for StreamWriter.start_tls()#101335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
kumaraditya303 merged 6 commits intopython:mainfrombeavailable:fix-issue-101317
Feb 1, 2023
Merged

gh-101317: Add ssl_shutdown_timeout parameter for StreamWriter.start_tls()#101335

kumaraditya303 merged 6 commits intopython:mainfrombeavailable:fix-issue-101317
Feb 1, 2023

Conversation

@beavailable
Copy link
Contributor

@beavailablebeavailable commentedJan 26, 2023•
edited
Loading

@bedevere-bot
Copy link

Most changes to Pythonrequire a NEWS entry.

Please add it using theblurb_it web app or theblurb command-line tool.

@ghost
Copy link

ghost commentedJan 26, 2023•
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

Copy link
Contributor

@kumaraditya303kumaraditya303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

You need to add this param to docs with a version changed directive.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@beavailable
Copy link
ContributorAuthor

I have made the requested changes; please review again.

@bedevere-bot
Copy link

Thanks for making the requested changes!

@kumaraditya303: please review the changes made to this pull request.

@kumaraditya303kumaraditya303 merged commitcc407b9 intopython:mainFeb 1, 2023
@kumaraditya303
Copy link
Contributor

Thanks.

@beavailablebeavailable deleted the fix-issue-101317 branchFebruary 1, 2023 11:05
carljm added a commit to carljm/cpython that referenced this pull requestFeb 1, 2023
* main:pythongh-98831: rewrite PUSH_EXC_INFO and conditional jumps in the instruction definition DSL (python#101481)pythongh-98831: Modernize the LOAD_ATTR family (python#101488)pythongh-101498 : Fix asyncio.Timeout example in docs (python#101499)pythongh-101454: fix documentation for END_ASYNC_FOR (python#101455)pythongh-101277: Isolate itertools, add group and _grouper types to module state (python#101302)pythongh-101317: Add `ssl_shutdown_timeout` parameter for `asyncio.StreamWriter.start_tls` (python#101335)  datetime.rst: fix combine() signature (python#101490)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@kumaraditya303kumaraditya303kumaraditya303 approved these changes

@1st11st1Awaiting requested review from 1st11st1 is a code owner

@asvetlovasvetlovAwaiting requested review from asvetlovasvetlov is a code owner

@gvanrossumgvanrossumAwaiting requested review from gvanrossum

Assignees

@kumaraditya303kumaraditya303

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Please add thessl_shutdown_timeout parameter forStreamWriter.start_tls() in asyncio

3 participants

@beavailable@bedevere-bot@kumaraditya303
[8]ページ先頭
©2009-2025 Movatter.jp