Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[3.11] GH-100762: Don't call gen.throw() in gen.close(), unless necessary#101316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

@markshannon
Copy link
Member

@markshannonmarkshannon commentedJan 25, 2023•
edited by bedevere-bot
Loading

This a backport of#101013 in principle, although the mechanism for determining when to skip the call tothrow() is different.

@markshannonmarkshannon added the 3.11only security fixes labelJan 25, 2023
@markshannonmarkshannon changed the title[3.11] Don't call gen.throw() in gen.close(), unless necessary[3.11] GH-100762: Don't call gen.throw() in gen.close(), unless necessaryJan 25, 2023
Copy link
Member

@brandtbucherbrandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Do we still want to do this? The code looks fine to me... I'm not sure why the tests are failing, but it definitely seems related.

@markshannon
Copy link
MemberAuthor

Given 3.13 will be released soon and this is working in 3.12, I don't think it is worth investigating further why this doesn't work.

@markshannonmarkshannon deleted the 100762-backport branchAugust 6, 2024 10:18
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@brandtbucherbrandtbucherbrandtbucher left review comments

@1st11st1Awaiting requested review from 1st11st1 is a code owner

Assignees

No one assigned

Labels

3.11only security fixesawaiting core review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@markshannon@brandtbucher@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp