Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-101277: Isolate itertools, part 3/4#101304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aaslanderlend-aasland commentedJan 24, 2023
edited by bedevere-bot
Loading

Add accumulate, compress, filterfalse, count, pairwise, zip_longest, and product types to module state

@erlend-aaslanderlend-aasland marked this pull request as ready for reviewFebruary 3, 2023 15:15
@erlend-aaslanderlend-aasland added the 🔨 test-with-refleak-buildbotsTest PR w/ refleak buildbots; report in status section labelFeb 3, 2023
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@erlend-aasland for commita02e90a 🤖

If you want to schedule another build, you need to add the:hammer: test-with-refleak-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-refleak-buildbotsTest PR w/ refleak buildbots; report in status section labelFeb 3, 2023
@erlend-aaslanderlend-aasland marked this pull request as draftFebruary 3, 2023 15:49
@erlend-aasland
Copy link
ContributorAuthor

@kumaraditya303: we're failingtest_finalize_structseq oftest_embed. the type version contract is invalidated1 and thePy_TPFLAGS_VALID_VERSION_TAG assert in_PyType_Lookup is triggered here:

if (entry->version==type->tp_version_tag&&
entry->name==name) {
assert(_PyType_HasFeature(type,Py_TPFLAGS_VALID_VERSION_TAG));
OBJECT_STAT_INC_COND(type_cache_hits, !is_dunder_name(name));
OBJECT_STAT_INC_COND(type_cache_dunder_hits,is_dunder_name(name));
returnentry->value;
}

AFAICS, the contract betweentp_version_tag andPy_TPFLAGS_VALID_VERSION_TAG seems to hold all across the APIs2 implemented typeobject.c, and from what I can see, the runtime uses only these APIs to mess with the type version.

Any ideas?

Footnotes

  1. tp_version_tag is set, buttp_flags & Py_TPFLAGS_VALID_VERSION_TAG is false

  2. PyType_Modified,assign_version_tag, etc.

@kumaraditya303
Copy link
Contributor

kumaraditya303 commentedFeb 7, 2023
edited
Loading

Hmm, debugging shows that it issys.int_info for which it is failing, this PR has nothing to with that so I guess it is a runtime bug somewhere.

Note for self:

Loop #2 ---\nobject address  : 0x5633734aa7e0\nobject refcount : 30\nobject type     : 0x563373352ce0\nobject type name: type\nobject repr     : <class 'sys.int_info'>\n_testembed: Objects/typeobject.c:4176: _PyType_Lookup: Assertion `_PyType_HasFeature(type, Py_TPFLAGS_VALID_VERSION_TAG)'

@erlend-aasland
Copy link
ContributorAuthor

Hmm, debugging shows that it issys.int_info for which it is failing, this PR has nothing to with that so I guess it is a runtime bug somewhere.

Hm, but it does not fail onmain; it only fails with this patch applied. I've tried (locally) to pull in latestmain, just to be sure.

@erlend-aasland

This comment was marked as outdated.

@erlend-aasland

This comment was marked as outdated.

@erlend-aasland
Copy link
ContributorAuthor

FTR, Kumar found the culprit. See#101696.

@erlend-aaslanderlend-aasland marked this pull request as ready for reviewFebruary 8, 2023 20:21
@erlend-aasland
Copy link
ContributorAuthor

Thanks, Kumar! Let's land.

@erlend-aaslanderlend-aasland merged commitde3669e intopython:mainFeb 8, 2023
@erlend-aaslanderlend-aasland deleted the isolate-itertools/batch-3 branchFebruary 8, 2023 20:25
carljm added a commit to carljm/cpython that referenced this pull requestFeb 9, 2023
* main: (82 commits)pythongh-101670: typo fix in PyImport_ExtendInittab() (python#101723)pythonGH-99293: Document that `Py_TPFLAGS_VALID_VERSION_TAG` shouldn't be used. (#pythonGH-101736)  no-issue: Add Dong-hee Na as the cjkcodecs codeowner (pythongh-101731)pythongh-101678: Merge math_1_to_whatever() and math_1() (python#101730)pythongh-101678: refactor the math module to use special functions from c11 (pythonGH-101679)pythongh-85984: Remove legacy Lib/pty.py code. (python#92365)pythongh-98831: Use opcode metadata for stack_effect() (python#101704)pythongh-101283: Version was just released, so should be changed in 3.11.3 (pythonGH-101719)pythongh-101283: Fix use of unbound variable (pythonGH-101712)pythongh-101283: Improved fallback logic for subprocess with shell=True on Windows (pythonGH-101286)pythongh-101277: Port more itertools static types to heap types (python#101304)pythongh-98831: Modernize CALL and family (python#101508)pythonGH-101696: invalidate type version tag in `_PyStaticType_Dealloc` (python#101697)pythongh-100221: Fix creating dirs in `make sharedinstall` (pythonGH-100329)pythongh-101670: typo fix in PyImport_AppendInittab() (pythonGH-101672)pythongh-101196: Make isdir/isfile/exists faster on Windows (pythonGH-101324)pythongh-101614: Don't treat python3_d.dll as a Python DLL when checking extension modules for incompatibility (pythonGH-101615)pythongh-100933: Improve `check_element` helper in `test_xml_etree` (python#100934)pythonGH-101578: Normalize the current exception (pythonGH-101607)pythongh-47937: Note that Popen attributes are read-only (python#93070)  ...
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@kumaraditya303kumaraditya303kumaraditya303 approved these changes

@rhettingerrhettingerAwaiting requested review from rhettingerrhettinger is a code owner

@corona10corona10Awaiting requested review from corona10

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@erlend-aasland@bedevere-bot@kumaraditya303

[8]ページ先頭

©2009-2025 Movatter.jp