Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.4k
gh-101277: Isolate itertools, part 2/4#101303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
kumaraditya303 merged 7 commits intopython:mainfromerlend-aasland:isolate-itertools/batch-2Feb 3, 2023
Merged
gh-101277: Isolate itertools, part 2/4#101303
kumaraditya303 merged 7 commits intopython:mainfromerlend-aasland:isolate-itertools/batch-2Feb 3, 2023
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
8a063a7 to2373926Compare2373926 to29a3485Comparebedevere-bot commentedFeb 1, 2023
corona10 approved these changesFeb 2, 2023
Member
corona10 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
lgtm!!
kumaraditya303 approved these changesFeb 3, 2023
Contributor
kumaraditya303 commentedFeb 3, 2023
Thanks@erlend-aasland, onto the next one! |
iritkatriel pushed a commit to iritkatriel/cpython that referenced this pull requestFeb 3, 2023
…thon#101303)Add dropwhile, takewhile, starmap, combinations*, and permutations types to module state.
ContributorAuthor
erlend-aasland commentedFeb 3, 2023
Thanks, Kumar! I'm on the road these days; I'll try to find the time to prepare part 3 later today. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Add dropwhile, takewhile, starmap, combinations*, and permutations types to module state