Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-101277: Isolate itertools, add group and _grouper types to module state#101302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@erlend-aasland
Copy link
Contributor

@erlend-aaslanderlend-aasland commentedJan 24, 2023•
edited by bedevere-bot
Loading

@erlend-aasland
Copy link
ContributorAuthor

This is part 1 of 4. I've split each PR so the diffs are ~200 lines of code, excluding clinic changes. This PR add helpers for fetching state, adds tests for type immutability, converts two of the types to heap types, and add them to the module state.

Follow-up PRs for the rest of the types are created as draft PRs; these will berebased ontomain after this PR has landed.

The last PR will purge the global-to-fix file, and add a NEWS entry.

@erlend-aaslanderlend-aasland added the 🔨 test-with-refleak-buildbotsTest PR w/ refleak buildbots; report in status section labelJan 25, 2023
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@erlend-aasland for commit6dc2032 🤖

If you want to schedule another build, you need to add the:hammer: test-with-refleak-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-refleak-buildbotsTest PR w/ refleak buildbots; report in status section labelJan 25, 2023
@rhettingerrhettinger removed their request for reviewJanuary 29, 2023 03:46
Copy link
Contributor

@kumaraditya303kumaraditya303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

erlend-aasland reacted with hooray emojierlend-aasland reacted with heart emoji
@erlend-aasland
Copy link
ContributorAuthor

Thanks for the reviews! Highly appreciated. I'm considering landing this tomorrow.

erlend-aaslandand others added2 commitsJanuary 31, 2023 19:03
Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
@erlend-aasland
Copy link
ContributorAuthor

I'm landing this shortly. I'll rebase#101303 ontomain and mark it as ready for review.

Thanks again for the reviews.

@erlend-aaslanderlend-aasland merged commit2b3e02a intopython:mainFeb 1, 2023
@erlend-aaslanderlend-aasland deleted the isolate-itertools/batch-1 branchFebruary 1, 2023 11:41
carljm added a commit to carljm/cpython that referenced this pull requestFeb 1, 2023
* main:pythongh-98831: rewrite PUSH_EXC_INFO and conditional jumps in the instruction definition DSL (python#101481)pythongh-98831: Modernize the LOAD_ATTR family (python#101488)pythongh-101498 : Fix asyncio.Timeout example in docs (python#101499)pythongh-101454: fix documentation for END_ASYNC_FOR (python#101455)pythongh-101277: Isolate itertools, add group and _grouper types to module state (python#101302)pythongh-101317: Add `ssl_shutdown_timeout` parameter for `asyncio.StreamWriter.start_tls` (python#101335)  datetime.rst: fix combine() signature (python#101490)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@rhettingerrhettingerrhettinger left review comments

@kumaraditya303kumaraditya303kumaraditya303 approved these changes

Assignees

@kumaraditya303kumaraditya303

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@erlend-aasland@bedevere-bot@rhettinger@kumaraditya303
[8]ページ先頭
©2009-2025 Movatter.jp