Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.3k
gh-92123: Adapt _elementtree to multi-phase init (PEP 489)#101285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
gh-92123: Adapt _elementtree to multi-phase init (PEP 489)#101285
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Pass state as arg to expat_set_error()
Pass state as arg to element_setstate_from_attributes()
Pass state as arg to element_setstate_from_Python()
bedevere-bot commentedJan 24, 2023
🤖 New build scheduled with the buildbot fleet by@erlend-aasland for commitde8ec94 🤖 If you want to schedule another build, you need to add the |
corona10 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Code change iteself looks good to me.
erlend-aasland commentedJan 24, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Thanks for the review; I'll merge as soon as the CI turns green. I'll give Kumar a chance to review it, so I'll wait with merging until tomorrow evening. |
vstinner commentedApr 5, 2023
Nicely done@erlend-aasland, that was a big one! |
Uh oh!
There was an error while loading.Please reload this page.