NotificationsYou must be signed in to change notification settings
Fork33.7k
Star70.4k

[3.11] gh-100795: Don't call freeaddrinfo on failure. (GH-101252)#101272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

miss-islington merged 1 commit intopython:3.11frommiss-islington:backport-b724ac2-3.11

Jan 23, 2023

Merged

[3.11] gh-100795: Don't call freeaddrinfo on failure. (GH-101252)#101272

miss-islington merged 1 commit intopython:3.11frommiss-islington:backport-b724ac2-3.11

Jan 23, 2023

Conversation

Copy link

Contributor

miss-islington commentedJan 23, 2023•
edited by arhadthedev
Loading

When getaddrinfo returns an error, the output pointer is in an unknown state
Don't call freeaddrinfo on it. See the issue for discussion and details with
links to reasoning.Most libc getaddrinfo implementations never modify the
output pointer unless they are returning success.

(cherry picked from commitb724ac2)

Co-authored-by: Gregory P. Smithgreg@krypto.org
Co-authored-by: Sergey G. Brestergithub@sebres.de
Co-authored-by: Oleg Iaryginoleg@arhadthedev.net

Issue:segfault in a docker container on host with ipv6 disabled when using getaddrinfo from socket.py #100795

pythongh-100795: Don't call freeaddrinfo on failure. (pythonGH-101252)

8c873c4

When getaddrinfo returns an error, the output pointer is in an unknown stateDon't call freeaddrinfo on it.  See the issue for discussion and details withlinks to reasoning.  _Most_ libc getaddrinfo implementations never modify theoutput pointer unless they are returning success.(cherry picked from commitb724ac2)Co-authored-by: Gregory P. Smith <greg@krypto.org>Co-authored-by: Sergey G. Brester <github@sebres.de>Co-authored-by: Oleg Iarygin <dralife@yandex.ru>