Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
gh-100795: Don't call freeaddrinfo on failure.#101252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
When getaddrinfo returns an error, the output pointer is in an unknown stateDon't call freeaddrinfo on it. See the issue for discussion and details withlinks to reasoning. _Most_ libc getaddrinfo implementations never modify theoutput pointer unless they are returning success.Co-authored-by: Sergey G. Brester <github@sebres.de>Co-authored-by: Oleg Iarygin <dralife@yandex.ru>
kumaraditya303 approved these changesJan 23, 2023
Contributor
miss-islington commentedJan 23, 2023
Thanks@gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
Contributor
miss-islington commentedJan 23, 2023
Sorry@gpshead, I had trouble checking out the |
Contributor
miss-islington commentedJan 23, 2023
Thanks@gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
bedevere-bot commentedJan 23, 2023
GH-101271 is a backport of this pull request to the3.10 branch. |
bedevere-bot commentedJan 23, 2023
GH-101272 is a backport of this pull request to the3.11 branch. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJan 23, 2023
When getaddrinfo returns an error, the output pointer is in an unknown stateDon't call freeaddrinfo on it. See the issue for discussion and details withlinks to reasoning. _Most_ libc getaddrinfo implementations never modify theoutput pointer unless they are returning success.(cherry picked from commitb724ac2)Co-authored-by: Gregory P. Smith <greg@krypto.org>Co-authored-by: Sergey G. Brester <github@sebres.de>Co-authored-by: Oleg Iarygin <dralife@yandex.ru>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJan 23, 2023
When getaddrinfo returns an error, the output pointer is in an unknown stateDon't call freeaddrinfo on it. See the issue for discussion and details withlinks to reasoning. _Most_ libc getaddrinfo implementations never modify theoutput pointer unless they are returning success.(cherry picked from commitb724ac2)Co-authored-by: Gregory P. Smith <greg@krypto.org>Co-authored-by: Sergey G. Brester <github@sebres.de>Co-authored-by: Oleg Iarygin <dralife@yandex.ru>
miss-islington added a commit that referenced this pull requestJan 23, 2023
When getaddrinfo returns an error, the output pointer is in an unknown stateDon't call freeaddrinfo on it. See the issue for discussion and details withlinks to reasoning. _Most_ libc getaddrinfo implementations never modify theoutput pointer unless they are returning success.(cherry picked from commitb724ac2)Co-authored-by: Gregory P. Smith <greg@krypto.org>Co-authored-by: Sergey G. Brester <github@sebres.de>Co-authored-by: Oleg Iarygin <dralife@yandex.ru>
miss-islington added a commit that referenced this pull requestJan 23, 2023
When getaddrinfo returns an error, the output pointer is in an unknown stateDon't call freeaddrinfo on it. See the issue for discussion and details withlinks to reasoning. _Most_ libc getaddrinfo implementations never modify theoutput pointer unless they are returning success.(cherry picked from commitb724ac2)Co-authored-by: Gregory P. Smith <greg@krypto.org>Co-authored-by: Sergey G. Brester <github@sebres.de>Co-authored-by: Oleg Iarygin <dralife@yandex.ru>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
When getaddrinfo returns an error, the output pointer is in an unknown state Don't call freeaddrinfo on it. See the issue for discussion and details with links to reasoning.Most libc getaddrinfo implementations never modify the output pointer unless they are returning success.
Co-authored-by: Sergey G. Brestergithub@sebres.de
Co-authored-by: Oleg Iaryginoleg@arhadthedev.net
This re-does the earlier merged and reverted PR with some additional comments.