Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[3.11] gh-100750: pass encoding kwarg in lib/platform.py (GH-100751)#101207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@miss-islington
Copy link
Contributor

@miss-islingtonmiss-islington commentedJan 20, 2023•
edited by bedevere-bot
Loading

(cherry picked from commit6b3993c)

Co-authored-by: Thomas Graingertagrain@gmail.com
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Shantanu12621235+hauntsaninja@users.noreply.github.com

)(cherry picked from commit6b3993c)Co-authored-by: Thomas Grainger <tagrain@gmail.com>Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
@miss-islingtonmiss-islington merged commitc6cfde6 intopython:3.11Jan 21, 2023
@miss-islingtonmiss-islington deleted the backport-6b3993c-3.11 branchJanuary 21, 2023 05:08
@malemburg
Copy link
Member

Shouldn't this instance of calling .check_output() also receive an encoding argument ?

https://github.com/python/cpython/blob/main/Lib/platform.py#L667

(in _syscmd_file())

@graingert
Copy link
Contributor

graingert commentedFeb 1, 2023•
edited
Loading

Shouldn't this instance of calling .check_output() also receive an encoding argument ?

main/Lib/platform.py#L667

(in _syscmd_file())

@malemburg no, that uses the defaulttext=False and then decodes the bytes object returned withlatin-1:

cpython/Lib/platform.py

Lines 667 to 676 in62251c3

output=subprocess.check_output(['file','-b',target],
stderr=subprocess.DEVNULL,
env=env)
except (OSError,subprocess.CalledProcessError):
returndefault
ifnotoutput:
returndefault
# With the C locale, the output should be mostly ASCII-compatible.
# Decode from Latin-1 to prevent Unicode decode error.
returnoutput.decode('latin-1')

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@hauntsaninjahauntsaninjahauntsaninja approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@miss-islington@malemburg@graingert@hauntsaninja@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp