Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-101152: Implement PEP 699#101193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Fidget-Spinner merged 16 commits intopython:mainfromramvikrams:t001
Jan 24, 2023
Merged

gh-101152: Implement PEP 699#101193

Fidget-Spinner merged 16 commits intopython:mainfromramvikrams:t001
Jan 24, 2023

Conversation

ramvikrams
Copy link
Contributor

@ramvikramsramvikrams commentedJan 20, 2023
edited
Loading

gh-101152: Added the PEP 699 Implementation

@Fidget-Spinner
Copy link
Member

  1. Please add news.
  2. The code looks similar to Kumar's. I'll add him as co-author when I merge.

@ramvikrams
Copy link
ContributorAuthor

  1. Please add news.
  2. The code looks similar to Kumar's. I'll add him as co-author when I merge.

added the news and infact it is a replica of his solution

Copy link
Member

@Fidget-SpinnerFidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Just some feedback for your future contributions:

  1. You can close conversations. Click on the "resolve conversation" button once you feel that you resolved the comment.
  2. reStructuredText markup is a little tricky! So you can refer to the devguide for thathttps://devguide.python.org/documentation/markup/
  3. I'll try to summarise what I look for in the Whats New deprecation. First you want to know exactlywhat is being affected (in this case the field of a certain struct being deprecated). Secondly, you want to know, without ambiguity, how we will notify users of this deprecation. In this case it's a compiler warning. Lastly, if there's a planned removal version for the deprecated thing, it should be mentioned too.

Thank you.

@Fidget-SpinnerFidget-Spinner changed the titlegh-101152: Added the PEP 699 Implementationgh-101152: Implement PEP 699Jan 21, 2023
ramvikramsand others added2 commitsJanuary 21, 2023 21:27
Co-authored-by: Ken Jin <kenjin@python.org>
…8pL.rstCo-authored-by: Ken Jin <kenjin@python.org>
@ramvikrams
Copy link
ContributorAuthor

Just some feedback for your future contributions:

The feedback was very helpful, will surely keep the points in mind.

Thanks

Copy link
Contributor

@kumaraditya303kumaraditya303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@Fidget-Spinner
Copy link
Member

Can you rebase with main and fix the conflicts in 3.12 whats new please? Seems like someone wrote an entry at the current spot.

@ramvikrams
Copy link
ContributorAuthor

Can you rebase with main and fix the conflicts in 3.12 whats new please? Seems like someone wrote an entry at the current spot.

yes sure

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@Fidget-SpinnerFidget-SpinnerFidget-Spinner approved these changes

@kumaraditya303kumaraditya303kumaraditya303 approved these changes

Assignees

@Fidget-SpinnerFidget-Spinner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@ramvikrams@Fidget-Spinner@kumaraditya303@bedevere-bot

[8]ページ先頭

©2009-2025 Movatter.jp