Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.4k
gh-101152: Implement PEP 699#101193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
gh-101152: Implement PEP 699#101193
Uh oh!
There was an error while loading.Please reload this page.
Conversation
|
added the news and infact it is a replica of his solution |
Misc/NEWS.d/next/Build/2023-01-21-10-31-35.gh-issue-101152.xvM8pL.rst OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Just some feedback for your future contributions:
- You can close conversations. Click on the "resolve conversation" button once you feel that you resolved the comment.
- reStructuredText markup is a little tricky! So you can refer to the devguide for thathttps://devguide.python.org/documentation/markup/
- I'll try to summarise what I look for in the Whats New deprecation. First you want to know exactlywhat is being affected (in this case the field of a certain struct being deprecated). Secondly, you want to know, without ambiguity, how we will notify users of this deprecation. In this case it's a compiler warning. Lastly, if there's a planned removal version for the deprecated thing, it should be mentioned too.
Thank you.
Uh oh!
There was an error while loading.Please reload this page.
Misc/NEWS.d/next/Build/2023-01-21-10-31-35.gh-issue-101152.xvM8pL.rst OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Ken Jin <kenjin@python.org>
…8pL.rstCo-authored-by: Ken Jin <kenjin@python.org>
The feedback was very helpful, will surely keep the points in mind. Thanks |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Ken Jin <kenjin@python.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
Can you rebase with main and fix the conflicts in 3.12 whats new please? Seems like someone wrote an entry at the current spot. |
yes sure |
Uh oh!
There was an error while loading.Please reload this page.
gh-101152: Added the PEP 699 Implementation