NotificationsYou must be signed in to change notification settings
Fork33.3k
Star69.8k

GH-92123: Store _elementtree state in type contexts#101190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

erlend-aasland merged 2 commits intopython:mainfromerlend-aasland:etree/state-as-type-context-member

Jan 23, 2023

Merged

GH-92123: Store _elementtree state in type contexts#101190

erlend-aasland merged 2 commits intopython:mainfromerlend-aasland:etree/state-as-type-context-member

Jan 23, 2023

Conversation

Copy link

Contributor

erlend-aasland commentedJan 20, 2023•
edited
Loading

Issue:[subinterpreters] crash in _elementtree when parsing in parallel #92123

bedevere-bot added the awaiting core review label

Jan 20, 2023

bedevere-bot mentioned this pull request

Jan 20, 2023

[subinterpreters] crash in _elementtree when parsing in parallel#92123

Closed

erlend-aasland added the skip news label

Jan 20, 2023

This comment was marked as outdated.

erlend-aasland force-pushed theetree/state-as-type-context-member branch fromb1127be tob2698e2Compare

January 21, 2023 11:32

erlend-aasland added2 commits

January 22, 2023 12:41

Store state in TreeBuilderObject context

dd92ea2

Store state in XMLParserObject context

4f0f2ff

erlend-aasland force-pushed theetree/state-as-type-context-member branch from007ccb5 to4f0f2ffCompare

January 22, 2023 11:43

Copy link

ContributorAuthor

erlend-aasland commentedJan 22, 2023

How about this: we store state in the type context for the TreeBuilder and XMLParser. The state pointer should be valid throughout the lifetime of the heap type, since each heap type has a reference to its module. After landing this, I'll rebase#101189 ontomain.

cc.@kumaraditya303,@arhadthedev