Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.1k
[3.10] gh-101144: Allow zipfile.Path .open & .read_text encoding to be positional (GH-101179)#101182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…g to be positional (pythonGH-101179)The zipfile.Path open() and read_text() encoding parameter can be supplied as a positional argument without causing a TypeError again. 3.10.0b1 included a regression that made it keyword only.Documentation update included as users writing code to be compatible with a wide range of versions will need to consider this for some time..(cherry picked from commit5927013)(cherry picked from commitefe3a38)Co-authored-by: Gregory P. Smith <greg@krypto.org>Co-authored-by: Gregory P. Smith <greg@krypto.org> [Google]
This was referencedJan 20, 2023
Closed
gpshead approved these changesJan 20, 2023
Status check is done, and it's a success ✅. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
The zipfile.Path open() and read_text() encoding parameter can be supplied as a positional argument without causing a TypeError again. 3.10.0b1 included a regression that made it keyword only.
Documentation update included as users writing code to be compatible with a wide range of versions will need to consider this for some time..
(cherry picked from commit5927013)
(cherry picked from commitefe3a38)
Co-authored-by: Gregory P. Smithgreg@krypto.org [Google]
zipfile.Path.read_text&.openmethods with a positionalencodingarg causes a TypeError #101144Automerge-Triggered-By: GH:gpshead