Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-94518: Renamegroup* toextra_group* to avoid confusion#101054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@arhadthedev
Copy link
Member

@arhadthedevarhadthedev commentedJan 15, 2023•
edited
Loading

This PR addresses#94687 (comment):

Todo: replacegroups_size/groups parameter names withextra_group_size/extra_groups across the whole file to avoid confusion of passers-by. It's necessary to mitigate a misleading name ofsetgroups that supposes replacement of not supplimentary group affinities, but all ones. The mislead results in seeing the omission ofsetgroups call forgroups_size == 0 as a bug (like we should reset the inherited affinities but do nothing instead).

I'll do it in a separate PR because both this PR andgh-94519 are already big enough to clobber them with extra details.

Edit: this PR also unifies terminology by further renaminggroups_list parameter andnum_groups variable intoextra_groups_packed andextra_group_size.

cc@gpshead

@arhadthedevarhadthedev marked this pull request as draftJanuary 15, 2023 09:17
@arhadthedev
Copy link
MemberAuthor

Converted to draft becausenum_groups andgroups_list seem to require renaming too.

@arhadthedevarhadthedev marked this pull request as ready for reviewJanuary 15, 2023 09:53
@arhadthedevarhadthedev marked this pull request as draftJanuary 15, 2023 10:33
@arhadthedev
Copy link
MemberAuthor

Converted to draft again to rerun tests because spuriousPermissionError: [WinError 32] The process cannot access the file because it is being used by another process: 'D:\\a\\cpython\\cpython\\build\\test_python_6372�\\test_python_worker_6400�'struck again on Windows x64.

@arhadthedevarhadthedev marked this pull request as ready for reviewJanuary 15, 2023 11:34
@arhadthedev
Copy link
MemberAuthor

Removed spuriously added technical_packed suffix from a Python signature offork_exec. It's relevant inside C code only (to distinguishPyObject andgid_t * variants ofextra_groups).

However, a newextra_groups argument name retains becausefork_exec arguments are positional-only.

@gpsheadgpshead merged commit73245d0 intopython:mainJan 26, 2023
@arhadthedevarhadthedev deleted the _posixsubprocess-rename-groups branchJanuary 26, 2023 07:05
mdboom pushed a commit to mdboom/cpython that referenced this pull requestJan 31, 2023
…ython#101054)* Rename `group*` to `extra_group*` to avoid confusion* Rename `num_groups` into `extra_group_size`* Rename `groups_list` to `extra_groups_packed`
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@gpsheadgpsheadgpshead approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@arhadthedev@gpshead@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp