NotificationsYou must be signed in to change notification settings
Fork33.3k
Star69.7k

gh-101046: Fix a potential memory leak in the parser when raising MemoryError#101051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

pablogsal merged 2 commits intopython:mainfrompablogsal:gh-101046

Jan 16, 2023

Merged

gh-101046: Fix a potential memory leak in the parser when raising MemoryError#101051

pablogsal merged 2 commits intopython:mainfrompablogsal:gh-101046

Jan 16, 2023

Conversation

Copy link

Member

pablogsal commentedJan 15, 2023•
edited by bedevere-bot
Loading

Issue:Potential memory leak in Parser/parser.c #101046

pythongh-101046: Fix a potential memory leak in the parser when raisi…

c4ea6fd

…ng MemoryError

pablogsal requested a review fromlysnikolaou as acode owner

January 15, 2023 03:27

bedevere-bot added the awaiting core review label

Jan 15, 2023

bedevere-bot mentioned this pull request

Jan 15, 2023

Potential memory leak in Parser/parser.c#101046

Closed

pablogsal added needs backport to 3.9 needs backport to 3.10

only security fixes

needs backport to 3.11only security fixes labels

Jan 15, 2023

kumaraditya303 reviewed

Jan 15, 2023

View reviewed changes

Tools/peg_generator/pegen/c_generator.py Outdated

		"void *_new_children = PyMem_Realloc(_children, _children_capacitysizeof(void *));"
		)
		self.out_of_memory_return(f"!_new_children")
		self.out_of_memory_return(f"!new_children",cleanup_code="PyMem_Free(_children);")

Copy link

Contributor

kumaraditya303Jan 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change

	self.out_of_memory_return(f"!new_children",cleanup_code="PyMem_Free(_children);")
	self.out_of_memory_return(f"!_new_children",cleanup_code="PyMem_Free(_children);")

fixup!pythongh-101046: Fix a potential memory leak in the parser whe…

f6814b6

…n raising MemoryError

lysnikolaou approved these changes

Jan 16, 2023

View reviewed changes

Copy link

Member

lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM!

bedevere-bot added awaiting merge and removed awaiting core review labels

Jan 16, 2023

pablogsal merged commit1de4395 intopython:main

Jan 16, 2023

pablogsal deleted the gh-101046 branch

January 16, 2023 18:45

Copy link

Contributor

miss-islington commentedJan 16, 2023

Thanks@pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10, 3.11.
🐍🍒⛏🤖

bedevere-bot removed the awaiting merge label

Jan 16, 2023

Copy link

Contributor

miss-islington commentedJan 16, 2023

Sorry,@pablogsal, I could not cleanly backport this to3.11 due to a conflict.
Please backport usingcherry_picker on command line.
cherry_picker 1de4395f62bb140563761ef5cbdf46accef3c550 3.11

miss-islington assignedpablogsal

Jan 16, 2023

Copy link

Contributor

miss-islington commentedJan 16, 2023

Sorry@pablogsal, I had trouble checking out the3.10 backport branch.
Please retry by removing and re-adding the "needs backport to 3.10" label.
Alternatively, you can backport usingcherry_picker on the command line.
cherry_picker 1de4395f62bb140563761ef5cbdf46accef3c550 3.10

Copy link

Contributor

miss-islington commentedJan 16, 2023

Sorry,@pablogsal, I could not cleanly backport this to3.9 due to a conflict.
Please backport usingcherry_picker on command line.
cherry_picker 1de4395f62bb140563761ef5cbdf46accef3c550 3.9

pablogsal added a commit to pablogsal/cpython that referenced this pull request

Jan 16, 2023

[3.11]pythongh-101046: Fix a potential memory leak in the parser whe…

16d932b

…n raising MemoryError (pythonGH-101051).(cherry picked from commit1de4395)Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>

Copy link

bedevere-bot commentedJan 16, 2023

GH-101085 is a backport of this pull request to the3.11 branch.

bedevere-bot removed the needs backport to 3.11only security fixes label

Jan 16, 2023

pablogsal added a commit to pablogsal/cpython that referenced this pull request

Jan 16, 2023

[3.10]pythongh-101046: Fix a potential memory leak in the parser whe…

5d2ff63

…n raising MemoryError (pythonGH-101051).(cherry picked from commit1de4395)Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>

Copy link

bedevere-bot commentedJan 16, 2023

GH-101086 is a backport of this pull request to the3.10 branch.

bedevere-bot removed the needs backport to 3.10only security fixes label

Jan 16, 2023

pablogsal added a commit that referenced this pull request

Jan 16, 2023

[3.10]gh-101046: Fix a potential memory leak in the parser when rais…

9345eea

…ing MemoryError (GH-101051). (#101086)Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>

pablogsal added a commit that referenced this pull request

Jan 16, 2023

[3.11]gh-101046: Fix a potential memory leak in the parser when rais…

31b82ab

…ing MemoryError (GH-101051) (#101085)Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>

Copy link

Member

hugovk commentedFeb 18, 2025

Sorry,@pablogsal, I could not cleanly backport this to3.9 due to a conflict. Please backport usingcherry_picker on command line.cherry_picker 1de4395f62bb140563761ef5cbdf46accef3c550 3.9

@pablogsal Does this still need backporting to 3.9? Otherwise let's remove the backport label.