Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-95299: Stop installing setuptools as a part of ensurepip and venv#101039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes fromall commits
Commits
Show all changes
21 commits Select commitHold shift + click to select a range
001ee43
Use environment variables to pass data into test setup script
pradyunsgb8421a1
Update test_cppext to stop invoking setuptools-based script as a CLI
pradyunsg9d343f2
Stop installing setuptools as a part of ensurepip and venv
pradyunsg4a51332
Correct the name of step in GitHub Action
pradyunsge0c53df
Drop most remaining references to `easy_install`
pradyunsg4c8e6be
fixup! Update test_cppext to stop invoking setuptools-based script as…
pradyunsgb489e52
fixup! Update test_cppext to stop invoking setuptools-based script as…
pradyunsgf308da4
Add a "What's New" entry for the setuptools removal
pradyunsg9579a3e
fixup! Add a "What's New" entry for the setuptools removal
pradyunsg0e2b55e
fixup! Add a "What's New" entry for the setuptools removal
pradyunsg0b8f384
Update Doc/whatsnew/3.12.rst
pradyunsg1262bee
Merge branch 'main' into remove-setuptools-ensurepip
arhadthedevbcda4cd
Merge branch 'main' into remove-setuptools-ensurepip
pradyunsge19784d
Update "Creating virtual environments" section to drop reference
pradyunsgea1bcea
Use the style suggested in review
pradyunsg5275f93
Use dirname on the absolute path
pradyunsg5c3ce99
Locate cppextdata with plain filesystem lookups
pradyunsg375b5c6
Merge branch 'main' into remove-setuptools-ensurepip
pradyunsg991d066
bundled pip -> bundled wheels
pradyunsgebf6c3b
Unbreak `test_cppext`
pradyunsgb83cf9f
:art:
pradyunsgFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
18 changes: 18 additions & 0 deletionsDoc/whatsnew/3.12.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -9,11 +9,9 @@ | ||
__all__ = ["version", "bootstrap"] | ||
_PACKAGE_NAMES = ('pip',) | ||
_PIP_VERSION = "23.0.1" | ||
_PROJECTS = [ | ||
("pip", _PIP_VERSION, "py3"), | ||
] | ||
@@ -153,17 +151,17 @@ def _bootstrap(*, root=None, upgrade=False, user=False, | ||
_disable_pip_configuration_settings() | ||
# By default, installing pip installs all of the | ||
# following scripts (X.Y == running Python version): | ||
# | ||
# pip, pipX, pipX.Y | ||
pradyunsg marked this conversation as resolved. Show resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
# | ||
# pip 1.5+ allows ensurepip to request that some of those be left out | ||
if altinstall: | ||
# omit pip, pipX | ||
os.environ["ENSUREPIP_OPTIONS"] = "altinstall" | ||
elif not default_pip: | ||
# omit pip | ||
os.environ["ENSUREPIP_OPTIONS"] = "install" | ||
with tempfile.TemporaryDirectory() as tmpdir: | ||
@@ -271,14 +269,14 @@ def _main(argv=None): | ||
action="store_true", | ||
default=False, | ||
help=("Make an alternate install, installing only the X.Y versioned " | ||
"scripts (Default: pipX, pipX.Y)."), | ||
) | ||
parser.add_argument( | ||
"--default-pip", | ||
action="store_true", | ||
default=False, | ||
help=("Make a default pip install, installing the unqualified pip " | ||
"in addition to the versioned scripts."), | ||
) | ||
args = parser.parse_args(argv) | ||
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletionsMisc/NEWS.d/next/Library/2023-01-14-17-54-56.gh-issue-95299.vUhpKz.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Remove the bundled setuptools wheel from ``ensurepip``, and stop installing setuptools in environments created by ``venv``. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.