Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-101006: Improve error handling when read marshal data#101007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchakaserhiy-storchaka commentedJan 13, 2023•
edited by bedevere-bot
Loading

  • EOFError no longer overrides other errors such as MemoryError or OSError at the start of the object.
  • Raise more relevant error when the NULL object occurs as a code object component.
  • Minimize an overhead of calling PyErr_Occurred().

* EOFError no longer overrides other errors such as MemoryError or OSError at  the start of the object.* Raise more relevant error when the NULL object occurs as a code object  component.* Minimize an overhead of calling PyErr_Occurred().
Copy link
Contributor

@erlend-aaslanderlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

After a quick review, this looks good to me. I'd like to take a closer look if you can wait for a day or two.

serhiy-storchakaand others added2 commitsMay 21, 2023 23:23
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@serhiy-storchakaserhiy-storchaka added the needs backport to 3.12only security fixes labelJun 29, 2023
@serhiy-storchakaserhiy-storchaka merged commit8bf6904 intopython:mainJun 29, 2023
@miss-islington
Copy link
Contributor

Thanks@serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@serhiy-storchakaserhiy-storchaka deleted the marshal-load-error-handling branchJune 29, 2023 09:22
@bedevere-bot
Copy link

GH-106226 is a backport of this pull request to the3.12 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.12only security fixes labelJun 29, 2023
@bedevere-bot
Copy link

GH-106227 is a backport of this pull request to the3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJun 29, 2023
…nGH-101007)* EOFError no longer overrides other errors such as MemoryError or OSError at  the start of the object.* Raise more relevant error when the NULL object occurs as a code object  component.* Minimize an overhead of calling PyErr_Occurred().(cherry picked from commit8bf6904)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-botbedevere-bot removed the needs backport to 3.11only security fixes labelJun 29, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJun 29, 2023
…nGH-101007)* EOFError no longer overrides other errors such as MemoryError or OSError at  the start of the object.* Raise more relevant error when the NULL object occurs as a code object  component.* Minimize an overhead of calling PyErr_Occurred().(cherry picked from commit8bf6904)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this pull requestJun 29, 2023
…01007) (GH-106226)* EOFError no longer overrides other errors such as MemoryError or OSError at  the start of the object.* Raise more relevant error when the NULL object occurs as a code object  component.* Minimize an overhead of calling PyErr_Occurred().(cherry picked from commit8bf6904)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this pull requestJun 29, 2023
…01007) (GH-106227)* EOFError no longer overrides other errors such as MemoryError or OSError at  the start of the object.* Raise more relevant error when the NULL object occurs as a code object  component.* Minimize an overhead of calling PyErr_Occurred().(cherry picked from commit8bf6904)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@arhadthedevarhadthedevarhadthedev left review comments

@erlend-aaslanderlend-aaslanderlend-aasland left review comments

@tirantiranAwaiting requested review from tiran

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

6 participants
@serhiy-storchaka@miss-islington@bedevere-bot@arhadthedev@erlend-aasland@hugovk
[8]ページ先頭
©2009-2025 Movatter.jp