Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-100668: Clarify how sqlite3 maps parameters onto placeholders#100960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@erlend-aasland
Copy link
Contributor

@erlend-aaslanderlend-aasland commentedJan 11, 2023•
edited by bedevere-bot
Loading

@bedevere-botbedevere-bot added awaiting core review docsDocumentation in the Doc dir skip news labelsJan 11, 2023
@erlend-aaslanderlend-aasland changed the titlegh-100668: Clarify how sqlite3 maps parameters onto placeholdersGH-100668: Clarify how sqlite3 maps parameters onto placeholdersJan 11, 2023
@erlend-aaslanderlend-aasland linked an issueJan 11, 2023 that may beclosed by this pull request
@erlend-aaslanderlend-aasland changed the titleGH-100668: Clarify how sqlite3 maps parameters onto placeholdersgh-100668: Clarify how sqlite3 maps parameters onto placeholdersJan 11, 2023
@erlend-aasland
Copy link
ContributorAuthor

What's up with Bedevere? The PR title is correct, and it points to a valid issue number.

@erlend-aasland
Copy link
ContributorAuthor

cc.@zzzeek

@CAM-Gerlach
Copy link
Member

What's up with Bedevere? The PR title is correct, and it points to a valid issue number.

Not 100% sure if you mean how come it didn't link the issue and the PR, or something else it did, but if you mean the former, it appears you added askip issue label when you submitted the PR, which made Bedevere not attempt to link it. I removed that, and everything appears to work fine.

erlend-aasland reacted with thumbs up emoji

Copy link
Member

@CAM-GerlachCAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

A few comments to fix some textual issues; otherwise, LGTM

@erlend-aaslanderlend-aasland merged commit206f05a intopython:mainJan 14, 2023
@miss-islington
Copy link
Contributor

Thanks@erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@erlend-aaslanderlend-aasland deleted the sqlite-docs/params-and-placeholders branchJanuary 14, 2023 22:58
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJan 14, 2023
pythonGH-100960)(cherry picked from commit206f05a)Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
@bedevere-bot
Copy link

GH-101044 is a backport of this pull request to the3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.11only security fixes labelJan 14, 2023
@bedevere-bot
Copy link

GH-101045 is a backport of this pull request to the3.10 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.10only security fixes labelJan 14, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJan 14, 2023
pythonGH-100960)(cherry picked from commit206f05a)Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
miss-islington added a commit that referenced this pull requestJan 14, 2023
…100960)(cherry picked from commit206f05a)Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
miss-islington added a commit that referenced this pull requestJan 14, 2023
…100960)(cherry picked from commit206f05a)Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@CAM-GerlachCAM-GerlachCAM-Gerlach left review comments

@berkerpeksagberkerpeksagAwaiting requested review from berkerpeksagberkerpeksag is a code owner

+1 more reviewer

@zzzeekzzzeekzzzeek left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docsDocumentation in the Doc dirskip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Clarify how sqlite3 maps parameters onto placeholders

5 participants

@erlend-aasland@CAM-Gerlach@miss-islington@bedevere-bot@zzzeek
[8]ページ先頭
©2009-2025 Movatter.jp