NotificationsYou must be signed in to change notification settings
Fork32.1k
Star67.3k

[3.7] Bump Azure Pipelines to ubuntu-20.04#100854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

hugovk wants to merge3 commits intopython:3.7fromhugovk:3.7-azure-pipelines-ubuntu-20.04

Closed

[3.7] Bump Azure Pipelines to ubuntu-20.04#100854

hugovk wants to merge3 commits intopython:3.7fromhugovk:3.7-azure-pipelines-ubuntu-20.04

Conversation

Copy link

Member

hugovk commentedJan 8, 2023•
edited
Loading

The 3.7 branch builds on Azure Pipelines is failing, for example:

##[warning]An image label with the label ubuntu-16.04 does not exist.,##[error]The remote provider was unable to process the request.

Themain and 3.11-3.8 branches were already bumped toubuntu-20.04 by#89170, which didn't make it back to 3.7.

Alternatively, we could useubuntu-22.04 for all branches, or theubuntu-latest alias which is now pointing toubuntu-22.04.

https://github.com/actions/runner-images#available-images

Bump Azure Pipelines to ubuntu-20.04

2b05fd9

bedevere-bot added the awaiting core review label

Jan 8, 2023

hugovk added the skip news label

Jan 8, 2023

hugovk force-pushed the3.7-azure-pipelines-ubuntu-20.04 branch fromb269d75 to2b05fd9Compare

January 8, 2023 15:57

Move triggers into YAML files

1e114b0

hugovk added the skip issue label

Jan 8, 2023

Copy link

MemberAuthor

hugovk commentedJan 8, 2023

Also included#21776 to move the triggers into the YAML files, which was backported down to 3.8, but not 3.7.

@zooba Do you know why this PR isn't triggering on Azure Pipelines?

Merge branch '3.7' into 3.7-azure-pipelines-ubuntu-20.04

570bb42

Copy link

Member

The PR trigger is overridden to only run on PRs to main, to avoid slowing down backports. And there's a separate build definition for CI builds (using the same YAML, and the default triggers for CI). I'm pretty sure triggers are only evaluated from the default branch's YAML, which isprobablymain.

Updating the OS images seems fine. I'd prefer to have it explicitly select an Ubuntu version - usinglatest is unfortunately asking for random warnings that may cause the build to look like a failure,though it is handy to get early notification of failures on the next OS... no way to win, unfortunately, but I'd rather not get the "about to change -latest" warnings here I think.