Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.3k
gh-100833: Remove 'volatile' qualifiers in fsum algorithm#100845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
mdickinson merged 5 commits intopython:mainfrommdickinson:experiment-remove-fsum-volatileJan 8, 2023
Merged
gh-100833: Remove 'volatile' qualifiers in fsum algorithm#100845
mdickinson merged 5 commits intopython:mainfrommdickinson:experiment-remove-fsum-volatileJan 8, 2023
+23 −22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
bedevere-bot commentedJan 8, 2023
🤖 New build scheduled with the buildbot fleet by@mdickinson for commit6b6631f 🤖 If you want to schedule another build, you need to add the |
This comment was marked as outdated.
This comment was marked as outdated.
bedevere-bot commentedJan 8, 2023
🤖 New build scheduled with the buildbot fleet by@mdickinson for commit9e5da47 🤖 If you want to schedule another build, you need to add the |
rhettinger approved these changesJan 8, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This PR removes the
volatilequalifier on various intermediate quantities in themath.fsumimplementation, and updates the notes preceding the algorithm accordingly (as well as fixing some of the exsting notes). See the linked issue for discussion.