Movatterモバイル変換

bedevere-bot mentioned this pull request

Clarify os.path.join documentation#100783

Closed

bedevere-bot added docs

Documentation in the Doc dir

skip news labels

hauntsaninja requested review fromJelleZijlstra andbarneygale

January 6, 2023 21:02

hauntsaninja added needs backport to 3.10

only security fixes

needs backport to 3.11only security fixes labels

eryksun reviewed

Doc/library/os.path.rst OutdatedShow resolvedHide resolved

eryksun reviewed

Doc/library/os.path.rst OutdatedShow resolvedHide resolved

hauntsaninja added2 commits

January 6, 2023 14:44

clarify "absolute"

5a3589b

change preposition

8c3acbf

Copy link

ContributorAuthor

hauntsaninja commentedJan 6, 2023

Thanks for the review, made the changes!

JelleZijlstra approved these changes

Jan 7, 2023

Copy link

Member

JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good, one nit in nearby code.

Doc/library/os.path.rst OutdatedShow resolvedHide resolved

bedevere-bot added awaiting merge and removed awaiting core review labels

Jan 7, 2023

Update Doc/library/os.path.rst

a2a6c81

hauntsaninja commented

Jan 7, 2023

Doc/library/os.path.rst OutdatedShow resolvedHide resolved

Update Doc/library/os.path.rst

4729442

eryksun reviewed

Doc/library/os.path.rstShow resolvedHide resolved

split sentences

403ef6e

hauntsaninja merged commit53455a3 intopython:main

Copy link

Contributor

miss-islington commentedJan 8, 2023

Thanks@hauntsaninja for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

bedevere-bot removed the awaiting merge label

hauntsaninja deleted the gh-100783 branch

January 8, 2023 08:51

Copy link

bedevere-bot commentedJan 8, 2023

GH-100843 is a backport of this pull request to the3.11 branch.

bedevere-bot removed the needs backport to 3.11only security fixes label

Copy link

bedevere-bot commentedJan 8, 2023

GH-100844 is a backport of this pull request to the3.10 branch.

bedevere-bot removed the needs backport to 3.10only security fixes label

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

pythongh-100783: fix os.path.join documentation (pythonGH-100811)

6860d99

- Use "drive", not "drive letter", because of UNC paths- Previous components are not thrown away from relative drive letters- Use "segment" instead of "component" for consistency with pathlib- Other miscellaneous improvements(cherry picked from commit53455a3)Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

pythongh-100783: fix os.path.join documentation (pythonGH-100811)

baefa55

- Use "drive", not "drive letter", because of UNC paths- Previous components are not thrown away from relative drive letters- Use "segment" instead of "component" for consistency with pathlib- Other miscellaneous improvements(cherry picked from commit53455a3)Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>

miss-islington added a commit that referenced this pull request

gh-100783: fix os.path.join documentation (GH-100811)

87076d8

- Use "drive", not "drive letter", because of UNC paths- Previous components are not thrown away from relative drive letters- Use "segment" instead of "component" for consistency with pathlib- Other miscellaneous improvements(cherry picked from commit53455a3)Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>

miss-islington added a commit that referenced this pull request

gh-77607: Improve accuracy of os.path.join docs#101406

gh-100783: fix os.path.join documentation (GH-100811)

fa8d396

- Use "drive", not "drive letter", because of UNC paths- Previous components are not thrown away from relative drive letters- Use "segment" instead of "component" for consistency with pathlib- Other miscellaneous improvements(cherry picked from commit53455a3)Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>

hauntsaninja added a commit to hauntsaninja/cpython that referenced this pull request

Jan 29, 2023

pythongh-77607: Improve accuracy of os.path.join docs

392c285

This is a follow-up topython#100811.One of the changes in that PR isn't accurate in that`os.path.join('', '')` will not end in a separator.This reverts that change to the previous wording that used "only", butexplicitly calls out the case where the last part ends in a separator,which is what caused confusin inpython#77607 and motivated the changeinpython#100811.

hauntsaninja mentioned this pull request

Jan 29, 2023

Merged

hauntsaninja added a commit that referenced this pull request

gh-77607: Improve accuracy of os.path.join docs (#101406)

909a674

This is a follow-up to#100811.One of the changes in that PR isn't accurate in that`os.path.join('', '')` will not end in a separator.This reverts that change to the previous wording that used "only", butexplicitly calls out the case where the last part ends in a separator,which is what caused confusin in#77607 and motivated the changein#100811.

miss-islington mentioned this pull request

[3.11] gh-77607: Improve accuracy of os.path.join docs (GH-101406)#101451

Merged

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

pythongh-77607: Improve accuracy of os.path.join docs (pythonGH-101406)

51b00e2

This is a follow-up topythonGH-100811.One of the changes in that PR isn't accurate in that`os.path.join('', '')` will not end in a separator.This reverts that change to the previous wording that used "only", butexplicitly calls out the case where the last part ends in a separator,which is what caused confusin inpythonGH-77607 and motivated the changeinpythonGH-100811.(cherry picked from commit909a674)Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>

miss-islington mentioned this pull request

[3.10] gh-77607: Improve accuracy of os.path.join docs (GH-101406)#101452

Merged

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

pythongh-77607: Improve accuracy of os.path.join docs (pythonGH-101406)

46a47ac

This is a follow-up topythonGH-100811.One of the changes in that PR isn't accurate in that`os.path.join('', '')` will not end in a separator.This reverts that change to the previous wording that used "only", butexplicitly calls out the case where the last part ends in a separator,which is what caused confusin inpythonGH-77607 and motivated the changeinpythonGH-100811.(cherry picked from commit909a674)Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>

miss-islington added a commit that referenced this pull request

gh-77607: Improve accuracy of os.path.join docs (GH-101406)

f36c272

This is a follow-up toGH-100811.One of the changes in that PR isn't accurate in that`os.path.join('', '')` will not end in a separator.This reverts that change to the previous wording that used "only", butexplicitly calls out the case where the last part ends in a separator,which is what caused confusin inGH-77607 and motivated the changeinGH-100811.(cherry picked from commit909a674)Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>

miss-islington added a commit that referenced this pull request

gh-77607: Improve accuracy of os.path.join docs (GH-101406)

a79dd88

This is a follow-up toGH-100811.One of the changes in that PR isn't accurate in that`os.path.join('', '')` will not end in a separator.This reverts that change to the previous wording that used "only", butexplicitly calls out the case where the last part ends in a separator,which is what caused confusin inGH-77607 and motivated the changeinGH-100811.(cherry picked from commit909a674)Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>

mdboom pushed a commit to mdboom/cpython that referenced this pull request