Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-100750: pass encoding kwarg in lib/platform.py#100751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ambv merged 5 commits intopython:mainfromgraingert:pass-encoding-kwarg-in-platform
Jan 20, 2023

Conversation

@graingert
Copy link
Contributor

@graingertgraingert commentedJan 4, 2023•
edited by bedevere-bot
Loading

@graingertgraingert changed the titlepass encoding='locale' kwarg in lib/platform.pygh-100750: pass encoding='locale' kwarg in lib/platform.pyJan 4, 2023
@graingertgraingert marked this pull request as ready for reviewJanuary 4, 2023 14:54
['uname','-p'],
stderr=subprocess.DEVNULL,
text=True,
encoding="locale",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I thinkuname output is not localized.
https://github.com/coreutils/coreutils/blob/8d4768c94d0fa9de545a6e1c370f9a6fae4cb3a7/src/uname.c#L314-L371

So we can use "utf-8" or "latin1" here.

@graingertgraingert changed the titlegh-100750: pass encoding='locale' kwarg in lib/platform.pygh-100750: pass encoding kwarg in lib/platform.pyJan 5, 2023
@ambvambv added the needs backport to 3.11only security fixes labelJan 20, 2023
@ambvambv merged commit6b3993c intopython:mainJan 20, 2023
@miss-islington
Copy link
Contributor

Thanks@graingert for the PR, and@ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJan 20, 2023
)(cherry picked from commit6b3993c)Co-authored-by: Thomas Grainger <tagrain@gmail.com>Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
@bedevere-bot
Copy link

GH-101207 is a backport of this pull request to the3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.11only security fixes labelJan 20, 2023
@graingertgraingert deleted the pass-encoding-kwarg-in-platform branchJanuary 20, 2023 22:43
miss-islington added a commit that referenced this pull requestJan 21, 2023
(cherry picked from commit6b3993c)Co-authored-by: Thomas Grainger <tagrain@gmail.com>Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
@jaracojaraco added the needs backport to 3.10only security fixes labelFeb 7, 2023
@miss-islington
Copy link
Contributor

Thanks@graingert for the PR, and@ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestFeb 7, 2023
)(cherry picked from commit6b3993c)Co-authored-by: Thomas Grainger <tagrain@gmail.com>Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
@bedevere-bot
Copy link

GH-101644 is a backport of this pull request to the3.10 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.10only security fixes labelFeb 7, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@methanemethanemethane approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@graingert@miss-islington@bedevere-bot@methane@ambv@jaraco@hauntsaninja
[8]ページ先頭
©2009-2025 Movatter.jp