Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-100689: Revert "bpo-41798: pyexpat: Allocate the expat_CAPI on the…#100745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
kumaraditya303 merged 8 commits intopython:mainfromsobolevn:issue-100689
Jan 8, 2023

Conversation

sobolevn
Copy link
Member

@sobolevnsobolevn commentedJan 4, 2023•
edited by bedevere-bot
Loading

… heap memory (GH-24061)"

This reverts commit7c83eaa.

This would need to be back-ported to 3.10 and 3.11

Copy link
Contributor

@kumaraditya303kumaraditya303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please add a news entry as this is a bug fix.

erlend-aasland reacted with thumbs up emoji
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be put in the comfy chair!

@sobolevn
Copy link
MemberAuthor

Done! I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@kumaraditya303: please review the changes made to this pull request.

@kumaraditya303kumaraditya303 added the type-crashA hard crash of the interpreter, possibly with a core dump labelJan 4, 2023
@SoulReaverFan
Copy link

Thank you so much for your work on fixing this issue. It is very much appreciated 👍

sobolevn reacted with heart emoji

@kumaraditya303kumaraditya303 merged commitb034fd3 intopython:mainJan 8, 2023
@miss-islington
Copy link
Contributor

Thanks@sobolevn for the PR, and@kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-100846 is a backport of this pull request to the3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.11only security fixes labelJan 8, 2023
@bedevere-bot
Copy link

GH-100847 is a backport of this pull request to the3.10 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.10only security fixes labelJan 8, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJan 8, 2023
…on the heap memory (pythonGH-24061)" (pythonGH-100745)*pythongh-100689: Revert "bpo-41798: pyexpat: Allocate the expat_CAPI on the heap memory (pythonGH-24061)"This reverts commit7c83eaa.(cherry picked from commitb034fd3)Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJan 8, 2023
…on the heap memory (pythonGH-24061)" (pythonGH-100745)*pythongh-100689: Revert "bpo-41798: pyexpat: Allocate the expat_CAPI on the heap memory (pythonGH-24061)"This reverts commit7c83eaa.(cherry picked from commitb034fd3)Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
miss-islington added a commit that referenced this pull requestJan 8, 2023
… heap memory (GH-24061)" (GH-100745)*gh-100689: Revert "bpo-41798: pyexpat: Allocate the expat_CAPI on the heap memory (GH-24061)"This reverts commit7c83eaa.(cherry picked from commitb034fd3)Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
kumaraditya303 pushed a commit that referenced this pull requestJan 8, 2023
… on the heap memory (GH-24061)" (GH-100745) (#100847)gh-100689: Revert "bpo-41798: pyexpat: Allocate the expat_CAPI on the heap memory (GH-24061)" (GH-100745)*gh-100689: Revert "bpo-41798: pyexpat: Allocate the expat_CAPI on the heap memory (GH-24061)"This reverts commit7c83eaa.(cherry picked from commitb034fd3)Co-authored-by: Nikita Sobolev <mail@sobolevn.me>Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@erlend-aaslanderlend-aaslanderlend-aasland approved these changes

@kumaraditya303kumaraditya303kumaraditya303 approved these changes

Assignees
No one assigned
Labels
release-blockertype-crashA hard crash of the interpreter, possibly with a core dump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

6 participants
@sobolevn@bedevere-bot@SoulReaverFan@miss-islington@erlend-aasland@kumaraditya303
[8]ページ先頭
©2009-2025 Movatter.jp