Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-100720: refactor calculation of number of frame slots for a code object into the new function _PyFrame_NumSlotsForCodeObject#100722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
iritkatriel merged 8 commits intopython:mainfromiritkatriel:num_registers
Jan 4, 2023

Conversation

@iritkatriel
Copy link
Member

@iritkatrieliritkatriel commentedJan 3, 2023•
edited
Loading

…code object into the new function _PyCode_GetNumFrameSlots
@iritkatrieliritkatriel added the interpreter-core(Objects, Python, Grammar, and Parser dirs) labelJan 3, 2023
Copy link
Member

@gvanrossumgvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, but let's ask@markshannon.

Copy link
Member

@markshannonmarkshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good, but I think_PyCode_GetNumFrameSlots should be an inline function.

}

int
_PyCode_GetNumFrameSlots(PyCodeObject*code)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This should probably be a static inline function.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yeah. I also think it belongs in pycore_frame.h rather than pycore_code.h.

@iritkatrieliritkatriel changed the titlegh-100720: refactor calculation of number of frame slots for a code object into the new function _PyCode_GetNumFrameSlotsgh-100720: refactor calculation of number of frame slots for a code object into the new function _PyFrame_NumSlotsForCodeObjectJan 4, 2023
@iritkatrieliritkatriel merged commitc31e356 intopython:mainJan 4, 2023
@iritkatrieliritkatriel deleted the num_registers branchJuly 25, 2023 18:08
@iritkatrieliritkatriel restored the num_registers branchJuly 25, 2023 18:08
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@gvanrossumgvanrossumgvanrossum approved these changes

@markshannonmarkshannonmarkshannon approved these changes

Assignees

No one assigned

Labels

interpreter-core(Objects, Python, Grammar, and Parser dirs)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add _PyFrame_NumSlotsForCodeObject()

4 participants

@iritkatriel@gvanrossum@markshannon@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp