Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

GH-100126: Skip incomplete frames in more places#100613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@brandtbucher
Copy link
Member

@brandtbucherbrandtbucher commentedDec 30, 2022•
edited by bedevere-bot
Loading

Also, add two new internal APIs (_PyFrame_GetComplete and_PyThreadState_GetFrame) to make this common move a bit cleaner.

@brandtbucherbrandtbucher added interpreter-core(Objects, Python, Grammar, and Parser dirs) release-blocker type-crashA hard crash of the interpreter, possibly with a core dump labelsDec 30, 2022
@brandtbucherbrandtbucher self-assigned thisDec 30, 2022
@brandtbucherbrandtbucher added the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelDec 30, 2022
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@brandtbucher for commit53d066e 🤖

If you want to schedule another build, you need to add the:hammer: test-with-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelDec 30, 2022
@brandtbucher
Copy link
MemberAuthor

The one failing buildbot (ARM64 Windows) has been failing on other PRs too.

Copy link
Member

@markshannonmarkshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

One quibble about naming.

Looks good. Hopefully this is the last of the frame stack traversal issues.

}

staticinline_PyInterpreterFrame*
_PyFrame_GetComplete(_PyInterpreterFrame*frame)
Copy link
Member

@markshannonmarkshannonJan 5, 2023•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This name gives no sense of traversing the stack until a complete frame is found.
Maybe_PyFrame_GetFirstComplete()?

brandtbucher reacted with thumbs up emoji
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@markshannonmarkshannonmarkshannon left review comments

Assignees

@brandtbucherbrandtbucher

Labels

interpreter-core(Objects, Python, Grammar, and Parser dirs)release-blockertype-crashA hard crash of the interpreter, possibly with a core dump

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brandtbucher@bedevere-bot@markshannon
[8]ページ先頭
©2009-2025 Movatter.jp