Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.1k
gh-100556: Betteror doc wording#100589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
AlexandroLuis left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
i wonder howand works if there's no comparison
justif x is false: x else: y
and notif x is True and y is True: True else: False
Thanks will do the change |
Doc/library/stdtypes.rst Outdated
| | | *y* | | | ||
| +-------------+---------------------------------+-------+ | ||
| | ``x and y`` | if *x* is True and *y* is True, | \(2) | | ||
| | | then True, else False | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think you misunderstood the other comment, as this now doesn't cover something like
>>> [] and [1][]
ramvikramsDec 30, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
could you please tell then how should it be framed, bcoz I am not able to think of it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
if x and y, then True, else False
it covers if it's Null, empty, False...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
thanks i'll do it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The original mention of 'true'/'false' refers to all truthy and falsey values, which include 0, None, empty lists, etc., and sayingTrue excludes those asTrue refers to just the boolean value. I also don't think that it's all that helpful for a table to have an entry to sayx and y then its explanation also sayx and y, so I would actually recommend just sticking with the original for thisand section.
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM IMO; it avoids a double negative (if false, else) and the order follows more closely with that of the expression itself
Thanks for the PR@ramvikrams |
Thanks@ramvikrams for the PR, and@erlend-aasland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
(cherry picked from commitb40dd71)Co-authored-by: ram vikram singh <ramvikrams243@gmail.com>Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
bedevere-bot commentedFeb 21, 2023
GH-102108 is a backport of this pull request to the3.11 branch. |
(cherry picked from commitb40dd71)Co-authored-by: ram vikram singh <ramvikrams243@gmail.com>Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
bedevere-bot commentedFeb 21, 2023
GH-102109 is a backport of this pull request to the3.10 branch. |
or doc workingor doc wordingOops, forgot to fix the title...hope you fixed it in the commit message :) |
I did... hope you like it 😄b40dd71 |
* main: (76 commits) Fix syntax error in struct doc example (python#102160)pythongh-99108: Import MD5 and SHA1 from HACL* (python#102089)pythonGH-101777: `queue.rst`: use 2 spaces after a period to be consistent. (python#102143) Few coverage nitpicks for the cmath module (python#102067)pythonGH-100982: Restrict `FOR_ITER_RANGE` to a single instruction to allow instrumentation. (pythonGH-101985)pythongh-102135: Update turtle docs to rename wikipedia demo to rosette (python#102137)pythongh-99942: python.pc on android/cygwin should link to libpython per configure.ac (pythonGH-100356)pythongh-95672 fix typo SkitTest to SkipTest (pythongh-102119)pythongh-101936: Update the default value of fp from io.StringIO to io.BytesIO (pythongh-102100)pythongh-102008: simplify test_except_star by using sys.exception() instead of sys.exc_info() (python#102009)pythongh-101903: Remove obsolete undefs for previously removed macros Py_EnterRecursiveCall and Py_LeaveRecursiveCall (python#101923)pythongh-100556: Improve clarity of `or` docs (python#100589)pythongh-101777: Make `PriorityQueue` docs slightly clearer (python#102026)pythongh-101965: Fix usage of Py_EnterRecursiveCall return value in _bisectmodule.c (pythonGH-101966)pythongh-101578: Amend exception docs (python#102057)pythongh-101961 fileinput.hookcompressed should not set the encoding value for the binary mode (pythongh-102068)pythongh-102056: Fix a few bugs in error handling of exception printing code (python#102078)pythongh-102011: use sys.exception() instead of sys.exc_info() in docs where possible (python#102012)pythongh-101566: Sync with zipp 3.14. (pythonGH-102018)pythonGH-99818: improve the documentation for zipfile.Path and Traversable (pythonGH-101589) ...
Oh, that's fine then of course :) At least for me updating the title-generated commit message updates the PR title as well, but it seems that's actually GitHub Refined rather than a builtin feature (I never know these days, heh) |
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
gh-100556: changed the or documentation