NotificationsYou must be signed in to change notification settings
Fork33.3k
Star69.8k

gh-100546: Remove incorrect positional-only marker from eval#100547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

hauntsaninja merged 1 commit intopython:mainfromhauntsaninja:fix-eval

Jan 1, 2023

Merged

gh-100546: Remove incorrect positional-only marker from eval#100547

hauntsaninja merged 1 commit intopython:mainfromhauntsaninja:fix-eval

Jan 1, 2023

Conversation

Copy link

Contributor

hauntsaninja commentedDec 27, 2022•
edited by bedevere-bot
Loading

All the arguments are positional-only.

The current status after#99476 seems to be to not use positional-only markers in documentation, hence I've simply removed it.

That said, there are still three other positional-only markers in this file). I asked for clarification in
#100546 (comment).
See also#98340

Issue:eval() documentation is wrong about keyword arguments #100546

pythongh-100546: Remove incorrect positional-only marker from eval

5f05995

All the arguments are positional-only.The current status afterpython#99476 seems to be to not use positional-onlymarkers in documentation, hence I've simply removed it.That said, there are still three other positional-only markers in thisfile).  I asked for clarification inpython#100546 (comment).See alsopython#98340

bedevere-bot mentioned this pull request

Dec 27, 2022

eval() documentation is wrong about keyword arguments#100546

Closed

bedevere-bot added awaiting core review docs

Documentation in the Doc dir

skip news labels

Dec 27, 2022

hauntsaninja added needs backport to 3.11

only security fixes

docs

Documentation in the Doc dir

awaiting core review skip news and removed docs

Documentation in the Doc dir

awaiting core review skip news labels

Dec 27, 2022

Copy link

ContributorAuthor

hauntsaninja commentedDec 27, 2022•
edited
Loading

Only needs backporting to 3.11 because#96579 (and subsequent partial reverts) only got backported to 3.11 (seems not particularly intentionally, seems just because automatic backporting failed)

sobolevn approved these changes

Dec 28, 2022

View reviewed changes

AlexWaygood approved these changes

Dec 30, 2022

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting core review labels

Dec 30, 2022

hauntsaninja merged commit71159a8 intopython:main

Jan 1, 2023

bedevere-bot removed the awaiting merge label

Jan 1, 2023

Copy link

Contributor

miss-islington commentedJan 1, 2023

Thanks@hauntsaninja for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

hauntsaninja deleted the fix-eval branch

January 1, 2023 00:59

Copy link

bedevere-bot commentedJan 1, 2023

GH-100654 is a backport of this pull request to the3.11 branch.

bedevere-bot removed the needs backport to 3.11only security fixes label

Jan 1, 2023

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jan 1, 2023

pythongh-100546: Remove incorrect positional-only marker from eval (p…

13173f8

…ythonGH-100547)All the arguments are positional-only.The current status afterpythonGH-99476 seems to be to not use positional-onlymarkers in documentation, hence I've simply removed it.(cherry picked from commit71159a8)Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>

miss-islington added a commit that referenced this pull request

Jan 1, 2023

gh-100546: Remove incorrect positional-only marker from eval (GH-100547)

7ed7127

All the arguments are positional-only.The current status afterGH-99476 seems to be to not use positional-onlymarkers in documentation, hence I've simply removed it.(cherry picked from commit71159a8)Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>