Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.3k
gh-100540: Remove obsolete '--with-system-ffi' configure option#100544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
It has had no effect on non-macOS platforms for a long time, and has hadthe non-obvious effect of invoking `pkg_config` and not setting`-DUSING_APPLE_OS_LIBFFI` on macOS sincepythonGH-22855.
bedevere-bot commentedDec 26, 2022
erlend-aasland approved these changesDec 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nice!
Gusse500 added a commit to Gusse500/LFS-Norsk that referenced this pull requestNov 1, 2023
Dette alternativet er fjernet av oppstrøms i 3.12.Link:python/cpython#100544
Poltern added a commit to Poltern/lfs-ru that referenced this pull requestNov 1, 2023
This option is removed by upstream in 3.12.Link:python/cpython#100544
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
3.12only security fixes buildThe build process and cross-build extension-modulesC modules in the Modules dir OS-mactopic-ctypes
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
It has had no effect on non-macOS platforms for a long time, and has had
the non-obvious effect of invoking
pkg_configand not setting-DUSING_APPLE_OS_LIBFFIon macOS sinceGH-22855._ctypes/libffibuild, particularly on macOS #100540