Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-100540: Remove obsolete Modules/_ctypes/darwin/ dlfcn shim#100541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
zware merged 1 commit intopython:mainfromzware:remove__ctypes_dlfcn_shim
Dec 29, 2022

Conversation

@zware
Copy link
Member

@zwarezware commentedDec 26, 2022•
edited by bedevere-bot
Loading

As far as I can tell, this hasn't been actually used since Mac OS X 10.2.

@zwarezware requested a review froma team as acode ownerDecember 26, 2022 20:54
@zwarezware added 3.12only security fixes OS-mac buildThe build process and cross-build topic-ctypes extension-modulesC modules in the Modules dir labelsDec 26, 2022
@zwarezware self-assigned thisDec 26, 2022
@zware
Copy link
MemberAuthor

zware commentedDec 26, 2022•
edited
Loading

!buildbot macos

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@zware for commit67d159c 🤖

The command will test the builders whose names match following regular expression:macOS

The builders matched are:

@zware
Copy link
MemberAuthor

!buildbot .*mac

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@zware for commit67d159c 🤖

The command will test the builders whose names match following regular expression:.*mac

The builders matched are:

  • ARM64 macOS PR
  • x86-64 macOS PR

@zwarezware requested a review froma teamDecember 26, 2022 21:00
@arhadthedev
Copy link
Member

Probably, this should be removed too:

#Modules/_ctypes/darwin/*.c

@zwarezwareforce-pushed theremove__ctypes_dlfcn_shim branch from67d159c to73b501eCompareDecember 27, 2022 19:30
@zware
Copy link
MemberAuthor

Probably, this should be removed too:

Ah, thanks; I missed that one here, though I got the neighboring one inGH-100543.

@zwarezwareforce-pushed theremove__ctypes_dlfcn_shim branch from73b501e tob2b2802CompareDecember 28, 2022 19:37
As far as I can tell, this hasn't been actually used since Mac OS X 10.2.
@zwarezwareforce-pushed theremove__ctypes_dlfcn_shim branch fromb2b2802 to2404f50CompareDecember 28, 2022 19:41
Copy link
Contributor

@ronaldoussorenronaldoussoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Patch looks good to me.

zware reacted with hooray emoji
@zwarezware merged commit2df82db intopython:mainDec 29, 2022
@zwarezware deleted the remove__ctypes_dlfcn_shim branchDecember 29, 2022 22:13
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@ronaldoussorenronaldoussorenronaldoussoren approved these changes

Assignees

@zwarezware

Labels

3.12only security fixesbuildThe build process and cross-buildextension-modulesC modules in the Modules dirOS-mactopic-ctypes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zware@bedevere-bot@arhadthedev@ronaldoussoren
[8]ページ先頭
©2009-2025 Movatter.jp