NotificationsYou must be signed in to change notification settings
Fork32k
Star67.3k

[3.10] gh-100474: Fix handling of dirs named index.html in http.server (GH-100504)#100504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

merwok merged 1 commit intopython:3.10frommiss-islington:backport-46e6a28-3.10

Dec 24, 2022

Merged

[3.10] gh-100474: Fix handling of dirs named index.html in http.server (GH-100504)#100504

merwok merged 1 commit intopython:3.10frommiss-islington:backport-46e6a28-3.10

Dec 24, 2022

Conversation

Copy link

Contributor

miss-islington commentedDec 24, 2022•
edited by merwok
Loading

If you had a directory called index.html or index.htm within a directory, it would cause http.server
to return a 404 Not Found error instead of the directory listing. This came about due to not checking
that the index was a regular file.

(cherry picked from commit46e6a28)

Co-authored-by: James Frostgit@frost.cx

Issue:http.server directories named index.html break directory listings #100474

pythongh-100474: Fix handling of dirs named index.html in http.server (…

1e07f77

…pythonGH-100475)If you had a directory called index.html or index.htm within a directory, it would cause http.server to return a 404 Not Found error instead of the directory listing. This came about due to not checking that the index was a regular file.I have also added a test case for this situation.(cherry picked from commit46e6a28)Co-authored-by: James Frost <git@frost.cx>Automerge-Triggered-By: GH:merwok

This was referencedDec 24, 2022

http.server directories named index.html break directory listings#100474

Closed

gh-100474: Fix handling of dirs named index.html in http.server#100475

Merged

bedevere-bot added type-bug

An unexpected behavior, bug, or error

awaiting review labels

Dec 24, 2022

merwok added the 🤖 automerge label

Dec 24, 2022

merwok approved these changes

Dec 24, 2022

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting review labels

Dec 24, 2022

merwok changed the title~~[3.10] gh-100474: Fix handling of dirs named index.html in http.server (GH-100475)~~[3.10] gh-100474: Fix handling of dirs named index.html in http.server (GH-100504)

Dec 24, 2022

merwok merged commitecbf136 intopython:3.10

Dec 24, 2022