Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
[3.11] gh-100160: Remove any deprecation warnings in asyncio.get_event_loop()#100412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[3.11] gh-100160: Remove any deprecation warnings in asyncio.get_event_loop()#100412
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…_loop()They are deferred to Python 3.12.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Obv. this is a draft PR so this review is also a draft. :-)
Uh oh!
There was an error while loading.Please reload this page.
Thank you for your review Guido. I switched it to draft to be sure that it will not be accidentally merged. The hard part in these PRs (#100410 and#100412) is documentation. It is difficult to find good place where all this mess should be documented, and I am bad in writing English. I think that non-documentation part is ready, but I am not sure about the documentation. Fill free to commit directly to this branch or create a new PR based on it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Here re a bunch of doc suggestions. I will merge those and then approve the PR.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Some more tense changes.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Thanks@serhiy-storchaka for the PR, and@gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10. |
Sorry,@serhiy-storchaka and@gvanrossum, I could not cleanly backport this to |
…ncio.get_event_loop() (pythonGH-100412)Some deprecation warnings will reappear (in a slightly different form) in 3.12.Co-authored-by: Guido van Rossum <guido@python.org>.(cherry picked from commit1b2459d)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
bedevere-bot commentedJan 12, 2023
GH-100970 is a backport of this pull request to the3.10 branch. |
Uh oh!
There was an error while loading.Please reload this page.
They are deferred to Python 3.12.