NotificationsYou must be signed in to change notification settings
Fork33.7k
Star70.4k

gh-99191: Use correct check for MSVC C++ version support in _wmimodule.cpp#100381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

zooba merged 2 commits intopython:mainfromCAM-Gerlach:fix-wmimodule-msvc-check

Jan 9, 2023

Merged

gh-99191: Use correct check for MSVC C++ version support in _wmimodule.cpp#100381

zooba merged 2 commits intopython:mainfromCAM-Gerlach:fix-wmimodule-msvc-check

Jan 9, 2023

Conversation

Copy link

Member

CAM-Gerlach commentedDec 20, 2022•
edited by bedevere-bot
Loading

As discussed in#99191 , inPC/_wmimodule.cpp it currently uses the check#if _MSC_VER >= 1929 to determine if the compiler supports C++20 designated initializers. However, the/std:c++20 flag was only introduced in VS 2019 16.11, but1929 is also the version reported in VS 2019 16.10, which doesn't support that flag. Therefore, the current check will break (resulting in the unsupported C++20 branch being taken and presumably resulting in a compiler error) on VS 16.10 and also if the build is invoked such that\std:c++20 is overridden or not passed.

However, we can instead use_MSVC_LANG >= 202002L to check whether C++20 or greater is actually being targeted.

Fixes#99191