Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-99942: python.pc on android/cygwin should link to libpython per configure.ac#100356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…roid/cygwinIn commit254b309 a previous change toavoid linking to libpython was partially reverted for Android (and laterCygwin as well), to add back the link flags. This was applied todistutils and to python-config.sh, but not to python.pc.Add it back to python.pc as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This looks correct to me, but I'd like someone else to also have a look if possible,
any opinion@freakboy3742 ? |
!buildbot Installed |
bedevere-bot commentedFeb 17, 2023
!buildbot .*Installed |
bedevere-bot commentedFeb 17, 2023
🤖 New build scheduled with the buildbot fleet by@gpshead for commit57e63ca 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
mhsmith commentedFeb 17, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Chaquopy doesn't currently use this .pc file, but this looks fine to me. |
FFY00 commentedFeb 17, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
The buildbot fails seem unrelated, I triggered a rebuild. |
dnicolodi commentedFeb 21, 2023
I don't see how this patch can cause the asyncio tests to fail or a stack overflow.@FFY00 can you restart the failed CI jobs? Should the PR be rebased to include some fixes landed in main in the meantime? |
Status check is done, and it's a success ✅. |
Thanks. Can this be backported to maintenance branches as well? |
* main: (76 commits) Fix syntax error in struct doc example (python#102160)pythongh-99108: Import MD5 and SHA1 from HACL* (python#102089)pythonGH-101777: `queue.rst`: use 2 spaces after a period to be consistent. (python#102143) Few coverage nitpicks for the cmath module (python#102067)pythonGH-100982: Restrict `FOR_ITER_RANGE` to a single instruction to allow instrumentation. (pythonGH-101985)pythongh-102135: Update turtle docs to rename wikipedia demo to rosette (python#102137)pythongh-99942: python.pc on android/cygwin should link to libpython per configure.ac (pythonGH-100356)pythongh-95672 fix typo SkitTest to SkipTest (pythongh-102119)pythongh-101936: Update the default value of fp from io.StringIO to io.BytesIO (pythongh-102100)pythongh-102008: simplify test_except_star by using sys.exception() instead of sys.exc_info() (python#102009)pythongh-101903: Remove obsolete undefs for previously removed macros Py_EnterRecursiveCall and Py_LeaveRecursiveCall (python#101923)pythongh-100556: Improve clarity of `or` docs (python#100589)pythongh-101777: Make `PriorityQueue` docs slightly clearer (python#102026)pythongh-101965: Fix usage of Py_EnterRecursiveCall return value in _bisectmodule.c (pythonGH-101966)pythongh-101578: Amend exception docs (python#102057)pythongh-101961 fileinput.hookcompressed should not set the encoding value for the binary mode (pythongh-102068)pythongh-102056: Fix a few bugs in error handling of exception printing code (python#102078)pythongh-102011: use sys.exception() instead of sys.exc_info() in docs where possible (python#102012)pythongh-101566: Sync with zipp 3.14. (pythonGH-102018)pythonGH-99818: improve the documentation for zipfile.Path and Traversable (pythonGH-101589) ...
Disagreement between distutils and sysconfig have been resolved forPython 3.12, seepython/cpython#100356 andpython/cpython#100967This is the other half of the fix formesonbuild#7702.
Disagreement between distutils and sysconfig have been resolved forPython 3.12, seepython/cpython#100356 andpython/cpython#100967This is the other half of the fix formesonbuild#7702.
Disagreement between distutils and sysconfig have been resolved forPython 3.12, seepython/cpython#100356 andpython/cpython#100967This is the other half of the fix formesonbuild#7702.
Disagreement between distutils and sysconfig have been resolved forPython 3.12, seepython/cpython#100356 andpython/cpython#100967This is the other half of the fix formesonbuild#7702.
…nt pythonOn python >=3.8, this information is expected to be encoded in thesysconfig vars.In distutils, it is always necessary to link to libpython on Windows;for posix platforms, it depends on the value of LIBPYTHON (which is thelibrary to link to, possibly the empty string) as generated byconfigure.ac and embedded into python.pc and python-config.sh, and thencoded a second time in the distutils python sources.There are a couple of caveats which have ramifications for Cygwin andAndroid:- python.pc and python-config.sh disagree with distutils when python is not built shared. In that case, the former act the same as a shared build, while the latter *never* links to libpython- python.pc disagrees with python-config.sh and distutils when python is built shared. The former never links to libpython, while the latter doThe disagreement is resolved in favor of distutils' behavior in allcases, and python.pc is correct for our purposes on python 3.12; see:python/cpython#100356python/cpython#100967Although it was not backported to older releases, Cygwin at least hasalways patched in a fix for python.pc, which behavior is now declaredcanonical. We can reliably assume it is always correct.This is the other half of the fix formesonbuild#7702
…nt pythonOn python >=3.8, this information is expected to be encoded in thesysconfig vars.In distutils, it is always necessary to link to libpython on Windows;for posix platforms, it depends on the value of LIBPYTHON (which is thelibrary to link to, possibly the empty string) as generated byconfigure.ac and embedded into python.pc and python-config.sh, and thencoded a second time in the distutils python sources.There are a couple of caveats which have ramifications for Cygwin andAndroid:- python.pc and python-config.sh disagree with distutils when python is not built shared. In that case, the former act the same as a shared build, while the latter *never* links to libpython- python.pc disagrees with python-config.sh and distutils when python is built shared. The former never links to libpython, while the latter doThe disagreement is resolved in favor of distutils' behavior in allcases, and python.pc is correct for our purposes on python 3.12; see:python/cpython#100356python/cpython#100967Although it was not backported to older releases, Cygwin at least hasalways patched in a fix for python.pc, which behavior is now declaredcanonical. We can reliably assume it is always correct.This is the other half of the fix formesonbuild#7702
…nt pythonOn python >=3.8, this information is expected to be encoded in thesysconfig vars.In distutils, it is always necessary to link to libpython on Windows;for posix platforms, it depends on the value of LIBPYTHON (which is thelibrary to link to, possibly the empty string) as generated byconfigure.ac and embedded into python.pc and python-config.sh, and thencoded a second time in the distutils python sources.There are a couple of caveats which have ramifications for Cygwin andAndroid:- python.pc and python-config.sh disagree with distutils when python is not built shared. In that case, the former act the same as a shared build, while the latter *never* links to libpython- python.pc disagrees with python-config.sh and distutils when python is built shared. The former never links to libpython, while the latter doThe disagreement is resolved in favor of distutils' behavior in allcases, and python.pc is correct for our purposes on python 3.12; see:python/cpython#100356python/cpython#100967Although it was not backported to older releases, Cygwin at least hasalways patched in a fix for python.pc, which behavior is now declaredcanonical. We can reliably assume it is always correct.This is the other half of the fix formesonbuild#7702(cherry picked from commit2d6c109)
…nt pythonOn python >=3.8, this information is expected to be encoded in thesysconfig vars.In distutils, it is always necessary to link to libpython on Windows;for posix platforms, it depends on the value of LIBPYTHON (which is thelibrary to link to, possibly the empty string) as generated byconfigure.ac and embedded into python.pc and python-config.sh, and thencoded a second time in the distutils python sources.There are a couple of caveats which have ramifications for Cygwin andAndroid:- python.pc and python-config.sh disagree with distutils when python is not built shared. In that case, the former act the same as a shared build, while the latter *never* links to libpython- python.pc disagrees with python-config.sh and distutils when python is built shared. The former never links to libpython, while the latter doThe disagreement is resolved in favor of distutils' behavior in allcases, and python.pc is correct for our purposes on python 3.12; see:python/cpython#100356python/cpython#100967Although it was not backported to older releases, Cygwin at least hasalways patched in a fix for python.pc, which behavior is now declaredcanonical. We can reliably assume it is always correct.This is the other half of the fix formesonbuild#7702
…nt pythonOn python >=3.8, this information is expected to be encoded in thesysconfig vars.In distutils, it is always necessary to link to libpython on Windows;for posix platforms, it depends on the value of LIBPYTHON (which is thelibrary to link to, possibly the empty string) as generated byconfigure.ac and embedded into python.pc and python-config.sh, and thencoded a second time in the distutils python sources.There are a couple of caveats which have ramifications for Cygwin andAndroid:- python.pc and python-config.sh disagree with distutils when python is not built shared. In that case, the former act the same as a shared build, while the latter *never* links to libpython- python.pc disagrees with python-config.sh and distutils when python is built shared. The former never links to libpython, while the latter doThe disagreement is resolved in favor of distutils' behavior in allcases, and python.pc is correct for our purposes on python 3.12; see:python/cpython#100356python/cpython#100967Although it was not backported to older releases, Cygwin at least hasalways patched in a fix for python.pc, which behavior is now declaredcanonical. We can reliably assume it is always correct.This is the other half of the fix for#7702
…per configure.ac (pythonGH-100356)In commit254b309 a previous change to avoid linking to libpython was partially reverted for Android (and later Cygwin as well), to add back the link flags. This was applied to distutils and to python-config.sh, but not to python.pc.Add it back to python.pc as well.Automerge-Triggered-By: GH:gpshead
…per configure.ac (pythonGH-100356)In commit254b309 a previous change to avoid linking to libpython was partially reverted for Android (and later Cygwin as well), to add back the link flags. This was applied to distutils and to python-config.sh, but not to python.pc.Add it back to python.pc as well.Automerge-Triggered-By: GH:gpshead
…per configure.ac (pythonGH-100356)In commit254b309 a previous change to avoid linking to libpython was partially reverted for Android (and later Cygwin as well), to add back the link flags. This was applied to distutils and to python-config.sh, but not to python.pc.Add it back to python.pc as well.Automerge-Triggered-By: GH:gpshead
…nt pythonOn python >=3.8, this information is expected to be encoded in thesysconfig vars.In distutils, it is always necessary to link to libpython on Windows;for posix platforms, it depends on the value of LIBPYTHON (which is thelibrary to link to, possibly the empty string) as generated byconfigure.ac and embedded into python.pc and python-config.sh, and thencoded a second time in the distutils python sources.There are a couple of caveats which have ramifications for Cygwin andAndroid:- python.pc and python-config.sh disagree with distutils when python is not built shared. In that case, the former act the same as a shared build, while the latter *never* links to libpython- python.pc disagrees with python-config.sh and distutils when python is built shared. The former never links to libpython, while the latter doThe disagreement is resolved in favor of distutils' behavior in allcases, and python.pc is correct for our purposes on python 3.12; see:python/cpython#100356python/cpython#100967Although it was not backported to older releases, Cygwin at least hasalways patched in a fix for python.pc, which behavior is now declaredcanonical. We can reliably assume it is always correct.This is the other half of the fix formesonbuild#7702
Uh oh!
There was an error while loading.Please reload this page.
In commit254b309 a previous change to avoid linking to libpython was partially reverted for Android (and later Cygwin as well), to add back the link flags. This was applied to distutils and to python-config.sh, but not to python.pc.
Add it back to python.pc as well.
Automerge-Triggered-By: GH:gpshead