Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-100340: Allows -Wno-int-conversion for wasm#100341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
kushaldas merged 1 commit intopython:mainfromkushaldas:wasi17_fix
Jan 18, 2023

Conversation

@kushaldas
Copy link
Member

@kushaldaskushaldas commentedDec 19, 2022•
edited by bedevere-bot
Loading

Adds new configuration directive to disableint-conversion and then using it for thewasm32-wasi build only. This allows us to build on the version 17 of the wasm-sdk.

How to test manually?

Install theversion 17 of the SDK and then run the following command:

./Tools/wasm/wasm_build.py wasi

@brettcannon
Copy link
Member

I looked at the output forhttps://buildbot.python.org/all/#/builders/1046 , but I couldn't find any way to tell what version of the WASI SDK was used to build Python. I know that@tiran set up the buildbots usinghttps://github.com/tiran/ansible-wasm-buildbot .

@kushaldas
Copy link
MemberAuthor

I looked at the output forhttps://buildbot.python.org/all/#/builders/1046 , but I couldn't find any way to tell what version of the WASI SDK was used to build Python. I know that@tiran set up the buildbots usinghttps://github.com/tiran/ansible-wasm-buildbot .

@brettcannon The buildbot is using version 16 according tohttps://github.com/tiran/ansible-wasm-buildbot/blob/main/roles/wasi-sdk/defaults/main.yml#L3

@kushaldaskushaldasforce-pushed thewasi17_fix branch 2 times, most recently from64a65f3 to8fe9902CompareDecember 20, 2022 08:34
Copy link
Contributor

@erlend-aaslanderlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM!

@kushaldas
Copy link
MemberAuthor

This worked onwasi-sdk-19 too.

@kushaldaskushaldas merged commit75c8133 intopython:mainJan 18, 2023
@brettcannon
Copy link
Member

@kushaldas any reason this wasn't backported?

@merwok
Copy link
Member

Came here from your recent blog post — as a small build change that can be considered a bug fix, and would give the benefit of keeping various python versions compatible with the latest wasi runtime, this seems fine to backport!

erlend-aasland reacted with thumbs up emoji

@merwokmerwok added the needs backport to 3.11only security fixes labelJun 24, 2023
@miss-islington
Copy link
Contributor

Thanks@kushaldas for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJun 24, 2023
FixespythonGH-100340 allows -Wno-int-conversion for wasm(cherry picked from commit75c8133)Co-authored-by: Kushal Das <mail@kushaldas.in>
@bedevere-bot
Copy link

GH-106066 is a backport of this pull request to the3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.11only security fixes labelJun 24, 2023
erlend-aasland pushed a commit that referenced this pull requestJun 28, 2023
…06066)(cherry picked from commit75c8133)Co-authored-by: Kushal Das <mail@kushaldas.in>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@brettcannonbrettcannonbrettcannon left review comments

@erlend-aaslanderlend-aaslanderlend-aasland approved these changes

@tirantiranAwaiting requested review from tiran

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@kushaldas@brettcannon@merwok@miss-islington@bedevere-bot@erlend-aasland
[8]ページ先頭
©2009-2025 Movatter.jp