Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-100321: Remove redundant variable newfree in function analyze_block#100327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
zikcheng wants to merge1 commit intopython:mainfromzikcheng:remove_newfree

Conversation

@zikcheng
Copy link
Contributor

@zikchengzikcheng commentedDec 18, 2022•
edited by bedevere-bot
Loading

Copy link
Contributor

@JosephSBoyleJosephSBoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hi.
What do the "newfree" and "allfree" vars represent?

@zikcheng
Copy link
ContributorAuthor

Hi@JosephSBoyle , in my understanding,allfree represents all free variables in children blocks andnewfree is just a copy ofallfree.

@JosephSBoyle
Copy link
Contributor

@zikcheng Thanks for clarifying for me:)

@encukou
Copy link
Member

In#101441, the allfree variable was removed instead.

Sorry that we missed this PR!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@iritkatrieliritkatrielAwaiting requested review from iritkatriel

@markshannonmarkshannonAwaiting requested review from markshannon

1 more reviewer

@JosephSBoyleJosephSBoyleJosephSBoyle left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zikcheng@JosephSBoyle@encukou@bedevere-bot@kumaraditya303
[8]ページ先頭
©2009-2025 Movatter.jp