Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.1k
GH-100222: Redefine _Py_CODEUNIT as a union to clarify structure of code unit.#100223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| uint16_t cache; | ||
| struct { | ||
| uint8_t opcode; | ||
| uint8_t oparg; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Is the idea to later add more opargs here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Up to you.
I guess it depends on how you want to align the instructions.
16 bit alignment
typedefunion {int16_tcache;struct {uint8_topcode;uint8_toparg0; };struct {uint8_toparg1;uint8_toparg2; };}_Py_CODEUNIT;
32 bit alignment
typedefunion {int32_tcache;struct {uint8_topcode;uint8_toparg0;uint8_toparg1;uint8_toparg2; };}_Py_CODEUNIT;
iritkatriel approved these changesDec 13, 2022
Closing and reopening to kick CI |
bedevere-bot commentedDec 14, 2022
|
Buildbot has run out of storage |
carljm added a commit to carljm/cpython that referenced this pull requestDec 14, 2022
* main: (103 commits)pythongh-100248: Add missing `ssl_shutdown_timeout` parameter in `asyncio` docs (python#100249) Assorted minor fixes for specialization stats. (pythonGH-100219)pythongh-100176: venv: Remove redundant compat code for Python <= 3.2 (python#100177)pythonGH-100222: Redefine _Py_CODEUNIT as a union to clarify structure of code unit. (pythonGH-100223)pythongh-99955: undef ERROR and SUCCESS before redefining (fixes sanitizer warning) (python#100215)pythonGH-100206: use versionadded for the addition of sysconfig.get_default_scheme (python#100207)pythongh-81057: Move _Py_RefTotal to the "Ignored Globals" List (pythongh-100203)pythongh-81057: Move Signal-Related Globals to _PyRuntimeState (pythongh-100085)pythongh-81057: Move faulthandler Globals to _PyRuntimeState (pythongh-100152)pythongh-81057: Move tracemalloc Globals to _PyRuntimeState (pythongh-100151)pythonGH-100143: Improve collecting pystats for parts of runs (pythonGH-100144)pythongh-99955: standardize return values of functions in compiler's code-gen (python#100010)pythongh-79218: Define `MS_WIN64` macro for Mingw-w64 64bit on Windows (pythonGH-100137) Fix: typo (Indention) (pythonGH-99904)pythongh-96715 Remove redundant NULL check in `profile_trampoline` function (python#96716)pythongh-100176: remove incorrect version compatibility check from argument clinic (python#100190) clarify the 4300-digit limit on int-str conversion (python#100175)pythongh-70393: Clarify mention of "middle" scope (python#98839)pythongh-99688: Fix outdated tests in test_unary (python#99712)pythongh-100174: [Enum] Correct PowersOfThree example. (pythonGH-100178) ...
miss-islington pushed a commit that referenced this pull requestDec 15, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Replaces
which omits important details and is arguably wrong, with
which is clearer both to me and to the compiler.