Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-100174: [Enum] Correct PowersOfThree example.#100178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ethanfurman merged 1 commit intopython:mainfromBeweeted:patch-1
Dec 11, 2022
Merged

gh-100174: [Enum] Correct PowersOfThree example.#100178

ethanfurman merged 1 commit intopython:mainfromBeweeted:patch-1
Dec 11, 2022

Conversation

Beweeted
Copy link
Contributor

@BeweetedBeweeted commentedDec 11, 2022•
edited by bedevere-bot
Loading

Changed from multiples of 3 to powers of 3 to match the class name.

Changed from multiples of 3 to powers of 3 to match the class name.
@ghost
Copy link

ghost commentedDec 11, 2022•
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@netlify
Copy link

netlifybot commentedDec 11, 2022•
edited
Loading

✅ Deploy Preview forpython-cpython-preview ready!

NameLink
🔨 Latest commit660d462
🔍 Latest deploy loghttps://app.netlify.com/sites/python-cpython-preview/deploys/63964cf6ac4fe9000810997b
😎 Deploy Previewhttps://deploy-preview-100178--python-cpython-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

@bedevere-botbedevere-bot added awaiting review docsDocumentation in the Doc dir skip news labelsDec 11, 2022
@AlexWaygood
Copy link
Member

Thanks! Unfortunately, nearly all Python PRs are made against themain branch, and then backported to maintenance branches after they've been merged. The best thing to do is to recreate the PR based againstmain.

@Beweeted
Copy link
ContributorAuthor

This is againstmain. I'm sure I missed something, but I couldn't find the button to make a new branch from the docs. I hitedit on the file, and it auto-forked it and gave me the option to merge it back in.

If you can point me in the right direction@AlexWaygood I'm happy to do the extra steps. Unless those steps are to sync & build the whole repo on my local, which is what the cpython docs were telling me to do.

Really, the most confusing thing is talking about backporting. Which I don't understand how that's applicable to this at all.

@AlexWaygood
Copy link
Member

AlexWaygood commentedDec 11, 2022•
edited
Loading

This is againstmain. I'm sure I missed something, but I couldn't find the button to make a new branch from the docs. I hitedit on the file, and it auto-forked it and gave me the option to merge it back in.

If you can point me in the right direction@AlexWaygood I'm happy to do the extra steps. Unless those steps are to sync & build the whole repo on my local, which is what the cpython docs were telling me to do.

Really, the most confusing thing is talking about backporting. Which I don't understand how that's applicable to this at all.

Apologies! Your PR title confused me. We usually use the[3.11] tag for PRs that are against the 3.11 branch.

The "backport" PR will be done automatically by a robot after this PR is merged. You won't need to worry about it.

@AlexWaygoodAlexWaygood changed the title[3.11] gh-100174: Fix math in PowersOfThree example class.[gh-100174: Fix math in PowersOfThree example class.Dec 11, 2022
@AlexWaygoodAlexWaygood changed the title[gh-100174: Fix math in PowersOfThree example class.gh-100174: Fix math in PowersOfThree example class.Dec 11, 2022
@AlexWaygood
Copy link
Member

We will need you to sign the CLA, however :)

@AlexWaygoodAlexWaygood added the needs backport to 3.11only security fixes labelDec 11, 2022
@Beweeted
Copy link
ContributorAuthor

Oh, oh oh. That makes sense. I had been seeing the other PRs and most seemed to have the version in the name. It wasn't mentioned in the comment, but I thought I was being a keener. I'll keep this in mind next time!

AlexWaygood and ethanfurman reacted with thumbs up emoji

@ethanfurmanethanfurman changed the titlegh-100174: Fix math in PowersOfThree example class.gh-100174: [Enum] Correct PowersOfThree example.Dec 11, 2022
@ethanfurmanethanfurman self-assigned thisDec 11, 2022
Copy link
Member

@ethanfurmanethanfurman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good! As soon as you sign the CLA we can merge this in.

@miss-islington
Copy link
Contributor

Thanks@Beweeted for the PR, and@ethanfurman for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-100181 is a backport of this pull request to the3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.11only security fixes labelDec 11, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestDec 11, 2022
Changed from multiples of 3 to powers of 3 to match the class name.(cherry picked from commit868bab0)Co-authored-by: Beweeted <Beweeted@users.noreply.github.com>
miss-islington added a commit that referenced this pull requestDec 11, 2022
Changed from multiples of 3 to powers of 3 to match the class name.(cherry picked from commit868bab0)Co-authored-by: Beweeted <Beweeted@users.noreply.github.com>
carljm added a commit to carljm/cpython that referenced this pull requestDec 14, 2022
* main: (103 commits)pythongh-100248: Add missing `ssl_shutdown_timeout` parameter in `asyncio` docs (python#100249)  Assorted minor fixes for specialization stats. (pythonGH-100219)pythongh-100176: venv: Remove redundant compat code for Python <= 3.2 (python#100177)pythonGH-100222: Redefine _Py_CODEUNIT as a union to clarify structure of code unit. (pythonGH-100223)pythongh-99955: undef ERROR and SUCCESS before redefining (fixes sanitizer warning) (python#100215)pythonGH-100206: use versionadded for the addition of sysconfig.get_default_scheme (python#100207)pythongh-81057: Move _Py_RefTotal to the "Ignored Globals" List (pythongh-100203)pythongh-81057: Move Signal-Related Globals to _PyRuntimeState (pythongh-100085)pythongh-81057: Move faulthandler Globals to _PyRuntimeState (pythongh-100152)pythongh-81057: Move tracemalloc Globals to _PyRuntimeState (pythongh-100151)pythonGH-100143: Improve collecting pystats for parts of runs (pythonGH-100144)pythongh-99955: standardize return values of functions in compiler's code-gen (python#100010)pythongh-79218: Define `MS_WIN64` macro for Mingw-w64 64bit on Windows (pythonGH-100137)  Fix: typo (Indention) (pythonGH-99904)pythongh-96715 Remove redundant NULL check in `profile_trampoline` function (python#96716)pythongh-100176: remove incorrect version compatibility check from argument clinic (python#100190)  clarify the 4300-digit limit on int-str conversion (python#100175)pythongh-70393: Clarify mention of "middle" scope (python#98839)pythongh-99688: Fix outdated tests in test_unary (python#99712)pythongh-100174: [Enum] Correct PowersOfThree example. (pythonGH-100178)  ...
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ethanfurmanethanfurmanethanfurman approved these changes

Assignees

@ethanfurmanethanfurman

Labels
docsDocumentation in the Doc dirskip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@Beweeted@AlexWaygood@miss-islington@bedevere-bot@ethanfurman
[8]ページ先頭
©2009-2025 Movatter.jp