NotificationsYou must be signed in to change notification settings
Fork32.1k
Star67.3k

gh-99952: [ctypes] fix refcount issues in from_param() result.#100169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

gpshead merged 8 commits intopython:mainfromynkdir:fix-issue-99952

Jan 26, 2023

Merged

gh-99952: [ctypes] fix refcount issues in from_param() result.#100169

gpshead merged 8 commits intopython:mainfromynkdir:fix-issue-99952

Jan 26, 2023

Conversation

Copy link

Contributor

ynkdir commentedDec 11, 2022•
edited by gpshead
Loading

Fixes a reference counting issue withctypes.Structure when afrom_param() method call is used and the structure size is larger than a C pointersizeof(void*).

This problem existed for a very long time, but became more apparent in 3.8+ by change likely due to garbage collection cleanup timing changes.

Issue:"a foreign function that will call a COM method" generated byctypes.WINFUNCTYPE works in Python3.7, does not work as same in newer Python #99952

ynkdir added2 commits

December 11, 2022 14:34

pythongh-99952: [ctypes] fix refcount issues in from_param() result.

aa88a61

add blurb

6084ba5

bedevere-bot mentioned this pull request

Dec 11, 2022

"a foreign function that will call a COM method" generated byctypes.WINFUNCTYPE works in Python3.7, does not work as same in newer Python#99952

Closed

bedevere-bot added the awaiting review label

Dec 11, 2022

Copy link

netlifybot commentedDec 11, 2022•
edited
Loading

✅ Deploy Preview forpython-cpython-preview canceled.

Name	Link
🔨 Latest commit	`ef884f1`
🔍 Latest deploy log	https://app.netlify.com/sites/python-cpython-preview/deploys/6395871f802ebd000860138d

Copy link

ghost commentedDec 11, 2022•
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.

ynkdir added2 commits

December 11, 2022 16:26

fix test

2fb9993

fix test

ef884f1

junkmd mentioned this pull request

Dec 11, 2022

Argument lifetime issue when calling COM/ATL methods with array of strings (and probably others) as of at least Python 3.8.3 (which worked with Python 3.7.x)enthought/comtypes#212

Closed

michaelDCurran mentioned this pull request

Dec 12, 2022

Task: Update to latest (most appropriate) version of Pythonnvaccess/nvda#12064

Closed

Copy link

ContributorAuthor

ynkdir commentedDec 12, 2022

related changelog
bpo-35947: Update windows to the current version of libffi#11797
bpo-37140: Fix StructUnionType_paramfunc()#15612

Copy link

Contributor

junkmd commentedDec 13, 2022

🚀

Merge branch 'main' into fix-issue-99952

63e5e35

kumaraditya303 requested a review fromFFY00

December 18, 2022 07:46

Copy link

Member

FFY00 commentedDec 19, 2022

I am not comfortable enough judging if this is the best/correct fix, but it seems like something that@vstinner might enjoy having a look at.

FFY00 removed their request for review

December 19, 2022 19:56

Copy link

Contributor

junkmd commentedDec 24, 2022

🎄 🎁 🧑‍🎄 🤶
Just remind.

junkmd mentioned this pull request

Dec 30, 2022

remove the outdated bridge forGUID.binaryenthought/comtypes#388

Closed

Copy link

dpy013 commentedJan 12, 2023

hello all
Is there an update on the current pr?

Copy link

Contributor

junkmd commentedJan 14, 2023•
edited
Loading

The absence of updates may be because theexpert-ctypes label is not attached to this PR, even though it is attached to issuegh-99952.

Looking at the PRs with theexpert-ctypes label that have been merged, I think the other core developers involved toctypes are@zware,@AA-Turner and@gpshead.

Triage and labeling to PRs seems to be done by@AlexWaygood.

I hope that they are aware of this ping and will respond.

Copy link

Member

zware commentedJan 16, 2023

This looks reasonable as far as I can tell, but unfortunately my expertise withctypes only extends as far as removing ancient copies oflibffi from the repository :)

zware added the topic-ctypes label

Jan 16, 2023

Merge branch 'main' into fix-issue-99952

8a305cf

gpshead self-assigned this

Jan 26, 2023

gpshead added needs backport to 3.10

only security fixes

needs backport to 3.11

only security fixes

type-bugAn unexpected behavior, bug, or error labels

Jan 26, 2023

gpshead added2 commits

January 25, 2023 23:54

add some comments.

a0b6672

ReSTify the NEWS entry.

cf33e7c

gpshead approved these changes

Jan 26, 2023

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting review labels

Jan 26, 2023

gpshead added 🤖 automerge and removed 🤖 automerge labels

Jan 26, 2023

gpshead merged commitdfad678 intopython:main

Jan 26, 2023

Copy link

Contributor

miss-islington commentedJan 26, 2023

Thanks@ynkdir for the PR, and@gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

bedevere-bot removed the awaiting merge label

Jan 26, 2023

Copy link

Member

gpshead commentedJan 26, 2023

Thanks everyone, this kind of bug can be particularly challenging to diagnose!

Copy link

Contributor

miss-islington commentedJan 26, 2023

Sorry,@ynkdir and@gpshead, I could not cleanly backport this to3.11 due to a conflict.
Please backport usingcherry_picker on command line.
cherry_picker dfad678d7024ab86d265d84ed45999e031a03691 3.11

Copy link

Contributor

miss-islington commentedJan 26, 2023

Sorry@ynkdir and@gpshead, I had trouble checking out the3.10 backport branch.
Please retry by removing and re-adding the "needs backport to 3.10" label.
Alternatively, you can backport usingcherry_picker on the command line.
cherry_picker dfad678d7024ab86d265d84ed45999e031a03691 3.10

gpshead mentioned this pull request

Jan 26, 2023

[3.11] gh-99952: fix refcount issues in ctypes.Structure from_param() result#101339

Merged

gpshead pushed a commit to gpshead/cpython that referenced this pull request

Jan 26, 2023

[3.11]pythongh-99952: [ctypes] fix refcount issues in from_param() r…

83cc74d

…esult. (pythonGH-100169)Fixes a reference counting issue with `ctypes.Structure` when a `from_param()` method call is used and the structure size is larger than a C pointer `sizeof(void*)`.This problem existed for a very long time, but became more apparent in 3.8+ by change likely due to garbage collection cleanup timing changes..(cherry picked from commitdfad678)Co-authored-by: Yukihiro Nakadaira <yukihiro.nakadaira@gmail.com>

miss-islington mentioned this pull request

Jan 26, 2023

[3.10] [3.11] gh-99952: fix refcount issues in ctypes.Structure from_param() result (GH-101339)#101340

Merged

gpshead added a commit that referenced this pull request

Jan 26, 2023

[3.11]gh-99952: fix refcount issues in ctypes.Structure from_param()…

fa7c37a

… result (#101339)[3.11]gh-99952: [ctypes] fix refcount issues in from_param() result. (GH-100169)Fixes a reference counting issue with `ctypes.Structure` when a `from_param()` method call is used and the structure size is larger than a C pointer `sizeof(void*)`.This problem existed for a very long time, but became more apparent in 3.8+ by change likely due to garbage collection cleanup timing changes..(cherry picked from commitdfad678)Co-authored-by: Yukihiro Nakadaira <yukihiro.nakadaira@gmail.com>

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jan 26, 2023

[3.11]pythongh-99952: fix refcount issues in ctypes.Structure from_p…

93f3978

…aram() result (pythonGH-101339)[3.11]pythongh-99952: [ctypes] fix refcount issues in from_param() result. (pythonGH-100169)Fixes a reference counting issue with `ctypes.Structure` when a `from_param()` method call is used and the structure size is larger than a C pointer `sizeof(void*)`.This problem existed for a very long time, but became more apparent in 3.8+ by change likely due to garbage collection cleanup timing changes..(cherry picked from commitdfad678)(cherry picked from commitfa7c37a)Co-authored-by: Gregory P. Smith <greg@krypto.org>Co-authored-by: Yukihiro Nakadaira <yukihiro.nakadaira@gmail.com>

Copy link

ContributorAuthor

ynkdir commentedJan 26, 2023

Thank you.

mdboom pushed a commit to mdboom/cpython that referenced this pull request

Jan 31, 2023

pythongh-99952: [ctypes] fix refcount issues in from_param() result. (p…

dd1590f

…ython#100169)Fixes a reference counting issue with `ctypes.Structure` when a `from_param()` method call is used and the structure size is larger than a C pointer `sizeof(void*)`.This problem existed for a very long time, but became more apparent in 3.8+ by change likely due to garbage collection cleanup timing changes.

gpshead added a commit that referenced this pull request

Feb 4, 2023

[3.10] [3.11]gh-99952: fix refcount issues in ctypes.Structure from_…

b134978

…param() result (GH-101339) (#101340)[3.11]gh-99952: [ctypes] fix refcount issues in from_param() result. (GH-100169)Fixes a reference counting issue with `ctypes.Structure` when a `from_param()` method call is used and the structure size is larger than a C pointer `sizeof(void*)`.This problem existed for a very long time, but became more apparent in 3.8+ by change likely due to garbage collection cleanup timing changes..(cherry picked from commitdfad678)(cherry picked from commitfa7c37a)Co-authored-by: Gregory P. Smith <greg@krypto.org>Co-authored-by: Yukihiro Nakadaira <yukihiro.nakadaira@gmail.com>Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>

zware removed needs backport to 3.10

only security fixes

needs backport to 3.11only security fixes labels

Apr 23, 2024