Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.4k
GH-100133: fixasyncio subprocess losingstderr andstdout output#100154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes from1 commit
Commits
Show all changes
9 commits Select commitHold shift + click to select a range
b980b7f wip
kumaraditya3036b9d8c1 add comment & test
kumaraditya303af1d4e6 fix comment
kumaraditya3036b87ae7 📜🤖 Added by blurb_it.
blurb-it[bot]3f55f14 use sys.executable
kumaraditya3032427537 Merge branch 'main' of https://github.com/python/cpython into fix-sub…
kumaraditya3034a55951 fix news
kumaraditya3036371452 fix import
kumaraditya303e9c8fce remove redundant code
kumaraditya303File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
use sys.executable
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commit3f55f146015170181e0e41b69ded0cb1ed69d5e0
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -697,7 +697,8 @@ async def get_command_stdout(cmd, *args): | ||
| async def main(): | ||
| outputs = [f'foo{i}' for i in range(10)] | ||
gvanrossum marked this conversation as resolved. Show resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
| res = await asyncio.gather(*[get_command_stdout(sys.executable, '-c', | ||
| f'import sys; print({out!r})') for out in outputs]) | ||
kumaraditya303 marked this conversation as resolved. OutdatedShow resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
| self.assertEqual(res, outputs) | ||
| self.loop.run_until_complete(main()) | ||
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.