Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.1k
gh-79218: DefineMS_WIN64 macro for Mingw-w64 64bit on Windows#100137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
netlifybot commentedDec 9, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
✅ Deploy Preview forpython-cpython-preview canceled.
|
ghost commentedDec 9, 2022 • edited by ghost
Loading Uh oh!
There was an error while loading.Please reload this page.
edited by ghost
Uh oh!
There was an error while loading.Please reload this page.
All commit authors signed the Contributor License Agreement. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This can be simplified down to only defineMS_WIN64, as the other variables are always defined unconditionally in this file.
(If Mingw isn't using the MSBuild files, then this change needs to go into the autoconf files for the generatedpyconfig.h. This header file is only used by thePCbuild build files, not viamake.)
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Fixed.
If cpython is compiled by MSBuild and cython extension is compiled by mingw-w64 (which is the most common case, I think), it works. If someone (for example, msys2) wants to compile cpython itself by mingw-w64, many patches will be required anyway. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Good to merge once CI passes
* main: (103 commits)pythongh-100248: Add missing `ssl_shutdown_timeout` parameter in `asyncio` docs (python#100249) Assorted minor fixes for specialization stats. (pythonGH-100219)pythongh-100176: venv: Remove redundant compat code for Python <= 3.2 (python#100177)pythonGH-100222: Redefine _Py_CODEUNIT as a union to clarify structure of code unit. (pythonGH-100223)pythongh-99955: undef ERROR and SUCCESS before redefining (fixes sanitizer warning) (python#100215)pythonGH-100206: use versionadded for the addition of sysconfig.get_default_scheme (python#100207)pythongh-81057: Move _Py_RefTotal to the "Ignored Globals" List (pythongh-100203)pythongh-81057: Move Signal-Related Globals to _PyRuntimeState (pythongh-100085)pythongh-81057: Move faulthandler Globals to _PyRuntimeState (pythongh-100152)pythongh-81057: Move tracemalloc Globals to _PyRuntimeState (pythongh-100151)pythonGH-100143: Improve collecting pystats for parts of runs (pythonGH-100144)pythongh-99955: standardize return values of functions in compiler's code-gen (python#100010)pythongh-79218: Define `MS_WIN64` macro for Mingw-w64 64bit on Windows (pythonGH-100137) Fix: typo (Indention) (pythonGH-99904)pythongh-96715 Remove redundant NULL check in `profile_trampoline` function (python#96716)pythongh-100176: remove incorrect version compatibility check from argument clinic (python#100190) clarify the 4300-digit limit on int-str conversion (python#100175)pythongh-70393: Clarify mention of "middle" scope (python#98839)pythongh-99688: Fix outdated tests in test_unary (python#99712)pythongh-100174: [Enum] Correct PowersOfThree example. (pythonGH-100178) ...
Uh oh!
There was an error while loading.Please reload this page.
Replacegh-19326.
Msys2 has fixed it for some time:
Co-authored-by: Алексейalexey.pawlow@gmail.com
Co-authored-by: Christoph Reiterreiter.christoph@gmail.com