Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-100110: Specialize FOR_ITER for tuples#100109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
markshannon merged 2 commits intopython:mainfromFidget-Spinner:for_iter_tuple
Dec 9, 2022

Conversation

@Fidget-Spinner
Copy link
Member

@Fidget-SpinnerFidget-Spinner commentedDec 8, 2022•
edited by bedevere-bot
Loading

@netlify
Copy link

netlifybot commentedDec 8, 2022•
edited
Loading

✅ Deploy Preview forpython-cpython-preview canceled.

NameLink
🔨 Latest commite3504e7
🔍 Latest deploy loghttps://app.netlify.com/sites/python-cpython-preview/deploys/6391d802c8b963000994af92

@Fidget-SpinnerFidget-Spinner changed the titleSpecialize FOR_ITER for tuplesgh-100110: Specialize FOR_ITER for tuplesDec 8, 2022
@markshannon
Copy link
Member

I'm not sure that I entirely trust those stats, yet.
They are probably right though, and I guess we can revert this if the stats prove to be wrong.

Copy link
Member

@markshannonmarkshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good.
Have you attempted to benchmark this?

@Fidget-Spinner
Copy link
MemberAuthor

Looks good. Have you attempted to benchmark this?

No. It's just one specialisation. I doubt anything in pyperformance will change.

@markshannon
Copy link
Member

markshannon commentedDec 8, 2022•
edited
Loading

I'm running the stats on it.
Partly to see if this PR makes the expected difference, and partly just to see if the stats workflow does what I expect.

Fidget-Spinner reacted with heart emoji

@markshannon
Copy link
Member

Thestats show what I would expect. No specialization failures for tuples, and an increase of hit rates forFOR_ITER from about 66% to 79%.

@markshannonmarkshannon merged commit748c6c0 intopython:mainDec 9, 2022
@Fidget-SpinnerFidget-Spinner deleted the for_iter_tuple branchDecember 10, 2022 13:08
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@markshannonmarkshannonmarkshannon approved these changes

@sweeneydesweeneydeAwaiting requested review from sweeneyde

@brandtbucherbrandtbucherAwaiting requested review from brandtbucher

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Fidget-Spinner@markshannon@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp