Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.1k
gh-98680: Add PyBUF_* constants to the Limited API listing#100018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
These were available in 3.11.0 with Py_LIMITED_API defined for 3.11,and are necessary to use the API.They should be considered part of the 3.11 Limited API.
Typo :-) |
vstinner approved these changesDec 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM.
Thanks@encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
bedevere-bot commentedDec 5, 2022
GH-100020 is a backport of this pull request to the3.11 branch. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestDec 5, 2022
…honGH-100018)``PyBUF_*`` constants are marked as part of Limited API of Python 3.11+.These were available in 3.11.0 with `Py_LIMITED_API` defined for 3.11,and are necessary to use the buffer API. Omitting them in `stable_abi.toml`was a mistake.(cherry picked from commitf247387)Co-authored-by: Petr Viktorin <encukou@gmail.com>
miss-islington added a commit that referenced this pull requestDec 5, 2022
``PyBUF_*`` constants are marked as part of Limited API of Python 3.11+.These were available in 3.11.0 with `Py_LIMITED_API` defined for 3.11,and are necessary to use the buffer API. Omitting them in `stable_abi.toml`was a mistake.(cherry picked from commitf247387)Co-authored-by: Petr Viktorin <encukou@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
PyBUF_*constants are marked as part of Limited API of Python 3.11+.These were available in 3.11.0 with
Py_LIMITED_APIdefined for 3.11, and are necessary to use the buffer API. Omitting them instable_abi.tomlwas a mistake.(cc@vstinner)