Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
Use faster APIs to calculate paths at startup for Store packaged Python on Windows#99345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
The rough testing I did showed about 50% reduction in startup time (~450ms->250ms) in non-ideal circumstances, but the Windows devs I was working with said it seemed right. The numbers were pretty stable. |
Okay, had to retract one of the major optimisations because it can be incorrect. That brings the improvement down to around 50ms, which is still worthwhile, but not as impressive. However, users can at least override this perf impact by setting their own |
It's possible we might be able to bring that optimisation back, looks like Windows covers the concerning edge cases for us. Still checking |
Thanks@zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
bedevere-bot commentedNov 23, 2022
GH-99733 is a backport of this pull request to the3.11 branch. |
…on on Windows (pythonGH-99345)(cherry picked from commit71a4a2d)Co-authored-by: Steve Dower <steve.dower@python.org>
bedevere-bot commentedNov 23, 2022
GH-99734 is a backport of this pull request to the3.10 branch. |
…on on Windows (pythonGH-99345)(cherry picked from commit71a4a2d)Co-authored-by: Steve Dower <steve.dower@python.org>
These APIs were added in Windows 8, so we can safely backport.