Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-87092: expose the compiler's codegen to python for unit tests#99111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
bedevere-bot commentedNov 5, 2022
🤖 New build scheduled with the buildbot fleet by@iritkatriel for commita2a1c17 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
bedevere-bot commentedNov 8, 2022
🤖 New build scheduled with the buildbot fleet by@iritkatriel for commit3c1c647 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
bedevere-bot commentedNov 8, 2022
🤖 New build scheduled with the buildbot fleet by@iritkatriel for commitd98f150 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
bedevere-bot commentedNov 9, 2022
🤖 New build scheduled with the buildbot fleet by@iritkatriel for commit00aea64 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
bedevere-bot commentedNov 10, 2022
🤖 New build scheduled with the buildbot fleet by@iritkatriel for commitab3f67c 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is a nice improvement.
I have a few questions and comments.
| @@ -40,6 +40,13 @@ extern int _PyAST_Optimize( | |||
| _PyASTOptimizeState *state); | |||
| /* Access compiler internals for unit testing */ | |||
| PyAPI_FUNC(PyObject*) _PyCompile_CodeGen( | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Does this (or the other functions) need to be an API function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Can _testinternalcapi import them otherwise?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think so, that why it has "internal" in the name.
It definesPy_BUILD_CORE_BUILTIN
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It doesn't seem to work:
[ERROR] _testinternalcapi failed to import: dlopen(/Users/iritkatriel/src/cpython-654/build/lib.macosx-13.0-x86_64-3.12-pydebug/_testinternalcapi.cpython-312d-darwin.so, 0x0002): symbol not found in flat namespace '__PyCompile_CodeGen'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'll merge this PR now, it's getting into merge conflicts all the time. We can remove these from the API later if it's possible.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
With this we can run just codegen from python, and get the un-optimized instruction sequence for an AST.